Skip to content

Wrong assembly version in Unquote.NetStandard #152

Closed

Description

@artemkv

Apprarently [<assembly: AssemblyVersion("5.0.0.0")>] in AssemblyInfo.fs is not respected anymore (https://stackoverflow.com/questions/42138418/equivalent-to-assemblyinfo-in-dotnet-core-csproj).

So the compiled dll that comes out from the build of Unquote.NetStandard has version 1.0.0

unquote
unquote1

This breaks other packages, like FSharp.AWS.DynamoDB that have Unquote as a dependency, at least when using the paket dependency manager.

When trying to use FSharp.AWS.DynamoDB which depends on Unquote, I am getting the error: Could not load file or assembly 'Unquote, Version=4.0.0.0, Culture=neutral, PublicKeyToken=null'. The located assembly's manifest definition does not match the assembly reference. (Exception from HRESULT: 0x80131040)

I cloned the repo and updated Unquote.NetStandard.fsproj by adding the following line to PropertyGroup: <Version>5.0.0</Version>. Then I re-compiled and manually replaced dll next to my project, then it worked.

Adding <GenerateAssemblyInfo>false</GenerateAssemblyInfo> to Unquote.NetStandard.fsproj also produced the dll with the correct version in manifest.

Could you please make sure that Unquote.NetStandard is build with the correct version?

Activity

  1. stephen-swensen commented on Sep 19, 2019

    @stephen-swensen
    Contributor

    Oh wow, thanks for detailed report! I'll try to get a fix out ASAP.

  2. stephen-swensen commented on Oct 27, 2020

    @stephen-swensen
    Contributor

    ASAP can be a long time for me these days... sorry. This is still on my radar though.

  3. added
    plannedIndicates a feature or bug is planned for inclusion in a future release
    on Oct 27, 2020
  4. added this to the 6.0.0 milestone on Apr 27, 2021
  5. stephen-swensen commented on Apr 27, 2021

    @stephen-swensen
    Contributor

    This will be fixed by #156

  6. stephen-swensen commented on Apr 30, 2021

    @stephen-swensen
    Contributor

    This is now released as part of Unquote 6.0.0! Thanks for your patience. A big part of Unquote 6.0.0 was modernizing build tooling which I hope will improve turn-around time for fixing issues like this including encouraging more contributions by the community.

  7. added a commit that references this issue on Apr 9, 2024
    78b0710
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugplannedIndicates a feature or bug is planned for inclusion in a future release

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions