Skip to content

Commit a8da2bc

Browse files
mgravellmgravell
authored
Drop explicit Microsoft.SourceLink.GitHub reference (#3222)
The .NET SDK has included and enabled Source Link for GitHub-hosted repos by default since 8.0.100; our pinned SDK is well past that. Referencing the package explicitly overrides the SDK's own version with ours, which is why we had to hand-bump it for a CVE in Microsoft.Build.Tasks.Git (#3210) - a class of maintenance the SDK now handles for us if we get out of its way. Verified the generated *.sourcelink.json and the packed nuspec <repository> element are unchanged across all six TFMs. Closes #3218
1 parent c1a317b commit a8da2bc

2 files changed

Lines changed: 0 additions & 2 deletions

File tree

‎Directory.Packages.props‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,6 @@
4040
<PackageVersion Include="Microsoft.CodeAnalysis.PublicApiAnalyzers" Version="5.6.0" />
4141
<PackageVersion Include="Microsoft.NETFramework.ReferenceAssemblies" Version="1.0.3" />
4242
<PackageVersion Include="Microsoft.NET.Test.Sdk" Version="18.3.0" />
43-
<PackageVersion Include="Microsoft.SourceLink.GitHub" Version="10.0.401" />
4443
<PackageVersion Include="Microsoft.Testing.Platform" Version="2.1.0" />
4544
<PackageVersion Include="Nerdbank.GitVersioning" Version="3.9.50" />
4645
<PackageVersion Include="Newtonsoft.Json" Version="13.0.4" />

‎src/Directory.Build.props‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@
1313
those are not part of the published surface and have no docs requirements. -->
1414
<PackageReference Include="StyleCop.Analyzers" PrivateAssets="All" />
1515
<PackageReference Include="Microsoft.CodeAnalysis.PublicApiAnalyzers" PrivateAssets="all" />
16-
<PackageReference Include="Microsoft.SourceLink.GitHub" PrivateAssets="all" />
1716
<PackageReference Include="Nerdbank.GitVersioning" PrivateAssets="all" Condition=" '$(DEVCONTAINER)' != 'true' " />
1817
</ItemGroup>
1918
<!-- shared NuGet package logo (assets/seredis.png at the repo root) -->

0 commit comments

Comments
 (0)