Skip to content

Commit 6af7089

Browse files
committed
Remove TODO’s no longer priority
1 parent 6b7820a commit 6af7089

3 files changed

Lines changed: 1 addition & 12 deletions

File tree

‎data_models/data_model_helpers.py‎

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -47,8 +47,6 @@ def convert_earthlocation_from_string(s: str):
4747
def convert_direction_to_string(d: SkyCoord):
4848
"""Convert SkyCoord to string
4949
50-
TODO: Make more general!
51-
5250
:param d: SkyCoord
5351
:return:
5452
"""
@@ -58,8 +56,6 @@ def convert_direction_to_string(d: SkyCoord):
5856
def convert_direction_from_string(s: str):
5957
"""Convert direction (SkyCoord) from string
6058
61-
TODO: Make more general!
62-
6359
:param s: String
6460
6561
:return:

‎processing_components/imaging/base.py‎

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -335,12 +335,6 @@ def create_image_from_visibility(vis: Union[BlockVisibility, Visibility], **kwar
335335
w.wcs.crval = [phasecentre.ra.deg, phasecentre.dec.deg, 1.0, reffrequency.to(units.Hz).value]
336336
w.naxis = 4
337337

338-
# TODO: Why is this check being done?
339-
# direction_centre = pixel_to_skycoord(npixel // 2 + 1, npixel // 2 + 1, wcs=w, origin=1)
340-
# assert direction_centre.separation(imagecentre).value < 1e-7, \
341-
# "Image phase centre [npixel//2, npixel//2] should be %s, actually is %s" % \
342-
# (str(imagecentre), str(direction_centre))
343-
344338
w.wcs.radesys = get_parameter(kwargs, 'frame', 'ICRS')
345339
w.wcs.equinox = get_parameter(kwargs, 'equinox', 2000.0)
346340

‎processing_components/imaging/primary_beams.py‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -358,13 +358,12 @@ def create_low_test_beam(model: Image, use_local=True) -> Image:
358358

359359

360360
def create_low_test_vp(model: Image, use_local=True) -> Image:
361-
"""Create a test power beam for LOW using an image from OSKAR
361+
"""Create a test power beam for LOW using an example image from OSKAR
362362
363363
:param model: Template image
364364
:return: Image
365365
"""
366366

367-
# TODO: Get true voltage beam from OSKAR
368367
beam = import_image_from_fits(arl_path('data/models/SKA1_LOW_beam.fits'))
369368
beam.data = numpy.sqrt(beam.data).astype('complex')
370369

0 commit comments

Comments
 (0)