Skip to content

Add actionlint step #7464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youknowone merged 6 commits into from
Mar 19, 2026
Merged

Add actionlint step #7464

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e0bf0f8
Add actionlint step
ShaharNaveh Mar 19, 2026
f04bf86
Fix some lints
ShaharNaveh Mar 19, 2026
06661df
Fix more lint
ShaharNaveh Mar 19, 2026
82ce530
More
ShaharNaveh Mar 19, 2026
751c8ce
Update .github/workflows/ci.yaml
ShaharNaveh Mar 19, 2026
9cb0400
More
ShaharNaveh Mar 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@

- name: Install dependencies
uses: ./.github/actions/install-linux-deps
with: ${{ matrix.dependencies || fromJSON('{}') }}

Check failure on line 144 in .github/workflows/ci.yaml

View workflow job for this annotation

GitHub Actions / format_check 

[actionlint] reported by reviewdog 🐶
"with" section is scalar node but mapping node is expected [syntax-check]

Raw Output:
e:.github/workflows/ci.yaml:144:15: "with" section is scalar node but mapping node is expected [syntax-check]

- uses: dtolnay/rust-toolchain@stable
with:
Expand Down Expand Up @@ -321,7 +321,7 @@

- name: run cpython tests to check if env polluters have stopped polluting
shell: bash
run: |

Check warning on line 324 in .github/workflows/ci.yaml

View workflow job for this annotation

GitHub Actions / format_check 

[actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2086:info:16:10: Double quote to prevent globbing and word splitting [shellcheck]

Raw Output:
i:.github/workflows/ci.yaml:324:9: shellcheck reported issue in this script: SC2086:info:16:10: Double quote to prevent globbing and word splitting [shellcheck]

Check warning on line 324 in .github/workflows/ci.yaml

View workflow job for this annotation

GitHub Actions / format_check 

[actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2086:info:12:8: Double quote to prevent globbing and word splitting [shellcheck]

Raw Output:
i:.github/workflows/ci.yaml:324:9: shellcheck reported issue in this script: SC2086:info:12:8: Double quote to prevent globbing and word splitting [shellcheck]
for thing in ${{ join(matrix.env_polluting_tests, ' ') }}; do
for i in $(seq 1 10); do
set +e
Expand Down Expand Up @@ -411,7 +411,9 @@
- run: ruff format --check

- name: install prettier
run: yarn global add prettier && echo "$(yarn global bin)" >>$GITHUB_PATH
run: |

Check warning on line 414 in .github/workflows/ci.yaml

View workflow job for this annotation

GitHub Actions / format_check 

[actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2086:info:2:20: Double quote to prevent globbing and word splitting [shellcheck]

Raw Output:
i:.github/workflows/ci.yaml:414:9: shellcheck reported issue in this script: SC2086:info:2:20: Double quote to prevent globbing and word splitting [shellcheck]
yarn global add prettier
yarn global bin >> $GITHUB_PATH
Comment thread
ShaharNaveh marked this conversation as resolved.
Resolved

- name: check wasm code with prettier
# prettier doesn't handle ignore files very well: https://github.com/prettier/prettier/issues/8506
Expand Down Expand Up @@ -486,7 +488,7 @@
cache: "npm"
cache-dependency-path: "wasm/demo/package-lock.json"
- name: run test
run: |

Check warning on line 491 in .github/workflows/ci.yaml

View workflow job for this annotation

GitHub Actions / format_check 

[actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2155:warning:1:8: Declare and assign separately to avoid masking return values [shellcheck]

Raw Output:
w:.github/workflows/ci.yaml:491:9: shellcheck reported issue in this script: SC2155:warning:1:8: Declare and assign separately to avoid masking return values [shellcheck]

Check failure on line 491 in .github/workflows/ci.yaml

View workflow job for this annotation

GitHub Actions / format_check 

[actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2006:style:1:19: Use $(...) notation instead of legacy backticks `...` [shellcheck]

Raw Output:
e:.github/workflows/ci.yaml:491:9: shellcheck reported issue in this script: SC2006:style:1:19: Use $(...) notation instead of legacy backticks `...` [shellcheck]
export PATH=$PATH:`pwd`/../../geckodriver
npm install
npm run test
Expand Down Expand Up @@ -551,6 +553,7 @@
- name: build rustpython
run: cargo build --release --target wasm32-wasip1 --features freeze-stdlib,stdlib --verbose
- name: run snippets
run: wasmer run --dir `pwd` target/wasm32-wasip1/release/rustpython.wasm -- `pwd`/extra_tests/snippets/stdlib_random.py

Check warning on line 556 in .github/workflows/ci.yaml

View workflow job for this annotation

GitHub Actions / format_check 

[actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2046:warning:1:72: Quote this to prevent word splitting [shellcheck]

Raw Output:
w:.github/workflows/ci.yaml:556:9: shellcheck reported issue in this script: SC2046:warning:1:72: Quote this to prevent word splitting [shellcheck]

Check warning on line 556 in .github/workflows/ci.yaml

View workflow job for this annotation

GitHub Actions / format_check 

[actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2046:warning:1:18: Quote this to prevent word splitting [shellcheck]

Raw Output:
w:.github/workflows/ci.yaml:556:9: shellcheck reported issue in this script: SC2046:warning:1:18: Quote this to prevent word splitting [shellcheck]

Check failure on line 556 in .github/workflows/ci.yaml

View workflow job for this annotation

GitHub Actions / format_check 

[actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2006:style:1:72: Use $(...) notation instead of legacy backticks `...` [shellcheck]

Raw Output:
e:.github/workflows/ci.yaml:556:9: shellcheck reported issue in this script: SC2006:style:1:72: Use $(...) notation instead of legacy backticks `...` [shellcheck]

Check failure on line 556 in .github/workflows/ci.yaml

View workflow job for this annotation

GitHub Actions / format_check 

[actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2006:style:1:18: Use $(...) notation instead of legacy backticks `...` [shellcheck]

Raw Output:
e:.github/workflows/ci.yaml:556:9: shellcheck reported issue in this script: SC2006:style:1:18: Use $(...) notation instead of legacy backticks `...` [shellcheck]
- name: run cpython unittest
run: wasmer run --dir `pwd` target/wasm32-wasip1/release/rustpython.wasm -- `pwd`/Lib/test/test_int.py

Check warning on line 558 in .github/workflows/ci.yaml

View workflow job for this annotation

GitHub Actions / format_check 

[actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2046:warning:1:72: Quote this to prevent word splitting [shellcheck]

Raw Output:
w:.github/workflows/ci.yaml:558:9: shellcheck reported issue in this script: SC2046:warning:1:72: Quote this to prevent word splitting [shellcheck]

Check warning on line 558 in .github/workflows/ci.yaml

View workflow job for this annotation

GitHub Actions / format_check 

[actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2046:warning:1:18: Quote this to prevent word splitting [shellcheck]

Raw Output:
w:.github/workflows/ci.yaml:558:9: shellcheck reported issue in this script: SC2046:warning:1:18: Quote this to prevent word splitting [shellcheck]

Check failure on line 558 in .github/workflows/ci.yaml

View workflow job for this annotation

GitHub Actions / format_check 

[actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2006:style:1:72: Use $(...) notation instead of legacy backticks `...` [shellcheck]

Raw Output:
e:.github/workflows/ci.yaml:558:9: shellcheck reported issue in this script: SC2006:style:1:72: Use $(...) notation instead of legacy backticks `...` [shellcheck]

Check failure on line 558 in .github/workflows/ci.yaml

View workflow job for this annotation

GitHub Actions / format_check 

[actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2006:style:1:18: Use $(...) notation instead of legacy backticks `...` [shellcheck]

Raw Output:
e:.github/workflows/ci.yaml:558:9: shellcheck reported issue in this script: SC2006:style:1:18: Use $(...) notation instead of legacy backticks `...` [shellcheck]

2 changes: 2 additions & 0 deletions .github/workflows/pr-format.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,8 @@ jobs:
with:
persist-credentials: false

- uses: reviewdog/action-actionlint@0d952c597ef8459f634d7145b0b044a9699e5e43 # v1.71.0

- name: Setup Rust
uses: dtolnay/rust-toolchain@stable
with:
Expand Down
Loading