Support locale for FormatSpec n #4613

Activity

1. youknowone

   added

   C-bugSomething isn't workingSomething isn't working

   C-compatA discrepancy between RustPython and CPythonA discrepancy between RustPython and CPython

   A-stdlib

   good first issueGood for newcomersGood for newcomers

   on Mar 2, 2023
2. deepakkrsoni commented on Sep 7, 2024

   

   deepakkrsoni

   on Sep 7, 2024

   More actions

   Hey i would like to contriubute to this issue, can you send me more details regarding the issue, and help me a bit to initiate with the issue ?
3. youknowone

   removed

   good first issueGood for newcomersGood for newcomers

   on Sep 8, 2024
4. youknowone commented on Sep 8, 2024

   

   youknowone

   on Sep 8, 2024

   MemberAuthor

   More actions

   @glitchxxx0 Hi! RustPython codebase is changed a lot since #4609 is written.

   Linux machine is recommended to run tests.

   1. Remove @unittest.expectedFailure from the test https://github.com/RustPython/RustPython/blob/main/Lib/test/test_types.py#L424-L425
   2. rustpython-format is now placed in different repository. This task will be multi-repository tasks. The relocated source code is here: https://github.com/RustPython/Parser/blob/main/format/src/format.rs
   3. FormatSpec::format_int have to take locale information from somewhere out of the format, which can be used for n format. Because FormatSpec or rustpython-format is not expected to know about platform-specific locale handling, there must be.. something to do it.

   Because many things are changed, I don't think this is a good first issue anymore.

   Since everybody has different view for problems, sharing everything about the issue is not easy. Please share me any blocking issues what makes you stuck or not to dive in coding. I'll try to catch what's missing for you.

   Thank you for visiting!
5. youknowone commented on Oct 7, 2026

   

   youknowone

   on Oct 7, 2026

   MemberAuthor

   More actions

   Locale-aware format spec n is implemented.

   format(1234567, "n") and format(1234.5, "n") match the active LC_NUMERIC grouping (verified for en_US.UTF-8 and de_DE.UTF-8). The related tests in Lib/test/test_types.py (test_int__format__locale, test_float__format__locale) are unmarked.

   Closing as resolved. Same work as #5181.

   — commented by Grok 4.6
6. youknowone

   closed this as completedon Oct 7, 2026