Repository navigation
Relocate object protocol implementation from vm #3324
Description
For now, Object protocol methods are (mostly) thin wrapper of matching vm functions. Because we don't need to have duplicated functions for same features, they need to be moved from vm to object protocol functions.
vmpath:vm/src/vm.rs- object protocol path:
vm/src/protocol/object.rs
The matching vm functions are easy to find because object methods are calling it.
- get_attr Relocate
vm.get_attributetoobj.get_attr#3331 - set_attr Relocate
vm.set_attrtoobj.set_attr#3338 - del_attr Relocate
vm.del_attrtoobj.del_attr#3341 - rich_compare Relocate
vm.rich_comparetoobj.rich_compare#3347 - repr Relocate
vm.to_reprtoobject.repr#3364 - str Relocate
vm.to_strtoobj.str#3349 - is_subclass Relocate vm.issubclass to obj.is_subclass #3345
- is_instance Relocate vm.isinstance to obj.is_instance #3344
- hash Relocate vm._hash to obj.hash #3342
- length Relocate vm.obj_len to obj.length #3343
Becasue relocating each function will cause many code editing, every new PR for each function is recommended for easier review.
Reference:
- Object protocol #3306: The original patch to add object protocol
Activity
Limits0x commentedon Oct 20, 2021
Should
call_special_methodbe moved intovm/src/protocol/object.rsas well ?DimitrisJim commentedon Oct 20, 2021
Nope, that's probably going to be part of another protocol file containing call related methods.
Limits0x commentedon Oct 20, 2021
So, that function can be called from
vm/src/protocol/object.rsasvm.call_special_method?DimitrisJim commentedon Oct 20, 2021
yeah, call it directly via
vmfor now.youknowone commentedon Oct 23, 2021
Thanks! This is finally done with all of your help!
ChJR commentedon Oct 23, 2021
Fabulous! I think this issue could be closed.
youknowone commentedon Nov 28, 2021
this is done! thank you everyone who contributed in this issue!