Dynamic rarity does not handle extremely rare species that didn't spawn in the time window #2469

Activity

1. pogo-excalibur commented on Jan 31, 2018

   

   pogo-excalibur

   on Jan 31, 2018

   Contributor

   More actions

   👍

   I think it would be reasonable to change:

   function getPokemonRarity(pokemonId) {
       if (pokemonRarities.hasOwnProperty(pokemonId)) {
           return pokemonRarities[pokemonId]
       }
   
       return ''
   }
   

   to

   function getPokemonRarity(pokemonId) {
       if (pokemonRarities.hasOwnProperty(pokemonId)) {
           return pokemonRarities[pokemonId]
       }
   
       return 'Ultra Rare'
   }
   

   As the only time a rarity should be undefined is if that pokemon hasn't been spotted in the dynamic rarity window.

   But we will need to consider the behaviour for short rarity windows - defaulting everything to Ultra Rare with a rarity window of 2-3 hours wouldn't work well.

   👍React with 👍1Reacted by darkelement1987
2. sebastienvercammen commented on Jan 31, 2018

   

   sebastienvercammen

   on Jan 31, 2018

   Member

   More actions

   @pogo-excalibur Same issue with new scans that don't have any entries yet. Defaulting to Ultra Rare would make all Pokémon (including Pidgeys) Ultra Rare in all instances until enough data was gathered.
3. sebastienvercammen

   added

   enhancement

   help wanted

   confirmed

   on Jan 31, 2018
4. sebastienvercammen

   added this to the 4.1.1 milestone on Jan 31, 2018
5. BrownSlaughter commented on Feb 9, 2018

   

   BrownSlaughter

   on Feb 9, 2018

   Contributor

   More actions

   

   A new spawn is not given a rarity until the rarity file is updated so is not removed via exclude by rarity.
   although this still leaves the issue of it being essentially an ultra rare but it would be next to invisible on a map.

   I have an idea of how to handle this that I will test and update