Skip to content

Commit 857d0d0

Browse files
yevhen-shyevhen-sh
authored
fix in requests.__version__ comparison
it might be a better solution, because i get: >>> import requests >>> requests.__version__ '2.18.4' >>> requests.__version__.split('.') < ['2','4','0'] True >>> from distutils.version import StrictVersion >>> StrictVersion(requests.__version__) < StrictVersion('2.4.0') False
1 parent f0f8863 commit 857d0d0

1 file changed

Lines changed: 2 additions & 1 deletion

File tree

‎adapters.py‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,8 @@
8888
# Requests older than 2.4.0's VerifiedHHTPSConnection is broken and doesn't
8989
# properly use _new_conn. On these versions, use UnverifiedHTTPSConnection
9090
# instead.
91-
if requests.__version__.split(".") < ['2', '4', '0']:
91+
from distutils.version import StrictVersion
92+
if StrictVersion(requests.__version__) < StrictVersion('2.4.0'):
9293
from requests.packages.urllib3.connection import (
9394
UnverifiedHTTPSConnection as HTTPSConnection
9495
)

0 commit comments

Comments
 (0)