Hi,
I noticed that RedisJSON module from Redis Stack v7.4.0-v0 is missing build information, resulting this message in Redis logs during load:
8635:M 00 Aug 2024 00:00:00 * <ReJSON> version: 20803 git sha: unknown branch: unknown
Then I decided to check manual build using official docs with steps like this:
git clone --recursive https://github.com/RedisJSON/RedisJSON.git --branch v2.8.3
make setup
make build
File rejson.so produced as a result has same unknown in both branch and sha in logs.
Looks like this code is used to provide this information during build time, but seems it's not working somehow.
So far I used workaround make build SHOW=1 GIT_BRANCH=v2.8.3 GIT_SHA=$(git rev-parse --short HEAD) to get proper build information:
10678:M 00 Aug 2024 00:00:00 * <ReJSON> version: 20803 git sha: 3e9a901 branch: v2.8.3
But it doesn't look like proper fix to me. Maybe I'm missing something?
Considering that official build from Redis Stack v7.4.0-v0 is also have this issue, doesn't look like.
Hi,
I noticed that RedisJSON module from Redis Stack v7.4.0-v0 is missing build information, resulting this message in Redis logs during load:
Then I decided to check manual build using official docs with steps like this:
File
rejson.soproduced as a result has sameunknownin both branch and sha in logs.Looks like this code is used to provide this information during build time, but seems it's not working somehow.
So far I used workaround
make build SHOW=1 GIT_BRANCH=v2.8.3 GIT_SHA=$(git rev-parse --short HEAD)to get proper build information:But it doesn't look like proper fix to me. Maybe I'm missing something?
Considering that official build from Redis Stack v7.4.0-v0 is also have this issue, doesn't look like.