Repository navigation
MOD-10798: Support K Ratio argument in FT.HYBRID vector query #8227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
b59f31e
WIP: Modify hybrid parser to support SHARD_K_RATIO
nafraf cbab449
Add HybridRequest_buildMRCommand + SHARD_K_RATIO unit tests
nafraf 3a9a8e6
Add test_shard_k_ratio_insufficient_docs()
nafraf 2220bda
fix: optimize SHARD_K_RATIO handling in MRCommand and improve test cases
nafraf 7bf9af3
Parse YIELD_SCORE_AS and SHARD_K_RATIO in a loop
nafraf 73e8b69
update ValidateShardKRatio() to return bool and MRCommand_appendVsim(…
nafraf 568b50a
Parse SHARD_K_RATIO as part of KNN clause
nafraf 5503047
fix: update HybridRequest_buildMRCommand to include EXEC_NO_FLAGS and…
nafraf c1bad99
Fix unit tests: SHARD_K_RATIO is part of KNN clause
nafraf f081c6f
handle shardKRatio as QueryAttribute
nafraf 2b1beb1
Verify docs per shard using profile
nafraf 2380b49
doc: clarify SHARD_K_RATIO applicability for KNN queries in MRCommand…
nafraf 96c80e6
Add shard_k_ratio parameter to FT commands_info.c and commands.json
nafraf daafdaa
Use rm_strndup for SHARD_K_RATIO value in parseShardKRatioClause
nafraf e56ef65
test: add helper function to validate VectorQuery in hybrid command t…
nafraf f8253cc
test: add helper function for SHARD_K_RATIO command transformation tests
nafraf 16d11d1
Fix HybridRequest_buildMRCommand: remove unused arg
nafraf f8c1313
refactor: change VectorQuery pointer to const in HybridRequest_buildM…
nafraf 639cc34
refactor: simplify hybrid command parsing and validation in tests
nafraf 400526a
refactor: move NumShards access into test function
nafraf 1da90c9
refactor: change VectorQuery pointers to const
nafraf 523d273
refactor: update macro definitions for command assertions to use do-w…
nafraf 810d0ff
refactor: add numShards to context structures and related functions f…
nafraf 963910a
refactor: add modifyVsimKNN()
nafraf 49b792f
update modifyVsimKNN() to include original K value for comparison
nafraf 227d912
Simplify SHARD_K_RATIO error handling and add tests for missing values
nafraf 69b357a
Add 'since' attribute to SHARD_K_RATIO and improve findKValue()
nafraf 8177afa
Address review comments in tests.
nafraf 3436088
Rename ValidateShardKRatio to validateShardKRatio for consistency in …
nafraf File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.