Skip to content
This repository was archived by the owner on Mar 27, 2024. It is now read-only.

Commit 9098666

Browse files
committed
Fixed incompat signature in ModularModuleTrait
1 parent bccdb97 commit 9098666

1 file changed

Lines changed: 8 additions & 5 deletions

File tree

‎src/Module/ModularModuleTrait.php‎

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,10 @@
22

33
namespace RebelCode\Modular\Module;
44

5+
use ArrayAccess;
56
use Dhii\Modular\Module\ModuleInterface;
67
use Psr\Container\ContainerInterface;
8+
use stdClass;
79
use Traversable;
810

911
/**
@@ -40,8 +42,8 @@ protected function _setup()
4042
$modules = $this->_getModules();
4143

4244
// Setup all modules and collect their containers
43-
$this->modules = array();
44-
$containers = array();
45+
$this->modules = [];
46+
$containers = [];
4547
foreach ($modules as $_module) {
4648
$_container = $_module->setup();
4749

@@ -84,15 +86,16 @@ protected function _run(ContainerInterface $c = null)
8486
abstract protected function _getModules();
8587

8688
/**
87-
* Creates a container instance with the given services.
89+
* Creates a container instance with the given service definitions.
8890
*
8991
* @since [*next-version*]
9092
*
91-
* @param mixed $services The services.
93+
* @param callable[]|ArrayAccess|stdClass|ContainerInterface $definitions The service definitions.
94+
* @param ContainerInterface|null $parent The parent container instance, if any.
9295
*
9396
* @return ContainerInterface The created container instance.
9497
*/
95-
abstract protected function _createContainer($services);
98+
abstract protected function _createContainer($definitions = [], ContainerInterface $parent = null);
9699

97100
/**
98101
* Creates a composite container with the given children container instances.

0 commit comments

Comments
 (0)