Skip to content
This repository was archived by the owner on Mar 27, 2024. It is now read-only.

Commit 837fcde

Browse files
committed
Fixed use of iterators in _setup()
1 parent ab3f17b commit 837fcde

1 file changed

Lines changed: 6 additions & 4 deletions

File tree

‎src/Module/ModularModuleTrait.php‎

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -37,17 +37,19 @@ trait ModularModuleTrait
3737
*/
3838
protected function _setup()
3939
{
40-
// Cache modules, in case the `_getModules()` call is expensive
41-
$this->modules = $this->_getModules();
40+
$modules = $this->_getModules();
4241

4342
// Setup all modules and collect their containers
43+
$this->modules = [];
4444
$containers = [];
45-
foreach ($this->modules as $_module) {
45+
foreach ($modules as $_module) {
4646
$_container = $_module->setup();
4747

4848
if ($_container !== null) {
4949
$containers[] = $_container;
5050
}
51+
52+
$this->modules[$_module->getKey()] = $_module;
5153
}
5254

5355
// Prepend a container with all module instances
@@ -77,7 +79,7 @@ protected function _run(ContainerInterface $c = null)
7779
*
7880
* @since [*next-version*]
7981
*
80-
* @return ModuleInterface[]|Traversable A list of module instances, mapped by their key.
82+
* @return ModuleInterface[]|Traversable A list of module instances.
8183
*/
8284
abstract protected function _getModules();
8385

0 commit comments

Comments
 (0)