Repository navigation
StringObservable.decode should call onError when buffer not empty on completion #32
Description
Activity
Sounds like a good idea to me.
It's not entirely obviously but it is actually the default behavior to replace malformed chars with a question mark char. It is possible to pass in a custom CharsetDecoder with different malformed handling. See http://docs.oracle.com/javase/7/docs/api/java/nio/charset/CodingErrorAction.html.
Consider just adding an overload that makes it easy to set that enum.
@davidmoten is this still an issue?
@abersnaze I imagine so. I like your suggestion. I'll pop this on my list of things to do.
At the moment if
StringObservable.decodeis called on a stream ofbyte[]and the source stream completes with bytes left over in the buffer (more is required before a string can be emitted) then the observable effectively hangs (onCompletedis not called). Because this situation cannot be distinguished from the source not completing or hanging I'd like to seeStringObservable.decodecallonErrorwith some custom exception type that can be ignored if people wish using the normal means.Are people ok with me submitting a PR for this?