Skip to content

Commit bd343f4

Browse files
HugoFaraHugoFara
committed
Fixed the audio player not having a play button.
1 parent e72fcf2 commit bd343f4

4 files changed

Lines changed: 26 additions & 26 deletions

File tree

‎css/jplayer.css‎

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎docs/CHANGELOG.md‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -27,9 +27,10 @@ For git tags, official releases are marked like "v1.0.0", while unofficial ones
2727
* The ability to use a dictionary with a specific encoding, introduced in 1.0.2, is being removed. It was making things overwhelmingly complex and caused issues, as signaled in [#58](https://github.com/HugoFara/lwt/issues/58). Adapted from PR [#59](https://github.com/HugoFara/lwt/pull/59).
2828

2929
### Fixed
30+
* The *audio* player was no onger working since 2.1.0-fork since the play button was hidden.
3031
* Testing specific terms was broken ([#66](https://github.com/HugoFara/lwt/issues/66)) and tests were sometimes not counting score. Solution inspired from PR [#67](https://github.com/HugoFara/lwt/issues/67) from [@jzohrab](https://github.com/jzohrab).
31-
* Right frames should hide automatically but they often don't [#61](https://github.com/HugoFara/lwt/issues/61). Merge PR (#62)[https://github.com/HugoFara/lwt/pull/62].
32-
* You should also see less annoying console messages of "cClick" crashing.
32+
* Right frames should hide automatically but they often don't ([#61](https://github.com/HugoFara/lwt/issues/61)). Merged PR (#62)[https://github.com/HugoFara/lwt/pull/62].
33+
* You should no longer see annoying console messages of "cClick" crashing on "obj is null".
3334
* Save text position (``inc/ajax_save_text_position.php``) was broken for all texts. This is fixed.
3435
* Type fixes thanks to psalm:
3536
* ``get_first_value`` documentation updated since it was also returning ``float`` and ``int``.
@@ -39,7 +40,6 @@ For git tags, official releases are marked like "v1.0.0", while unofficial ones
3940
* Unconsistent option in ``inc/ajax_save_setting.php``.
4041
* Since 2.2.2-fork, you had to use a GET request to use it, resulting in authorization errors.
4142
* POST requests are now again the default way to use it.
42-
* Removed the last JS error messages of "obj is null" when calling ``cClick``.
4343
* Sometimes tests were loop-reloading clicking after setting new status, this is fixed.
4444

4545

‎docs/info.html‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1949,10 +1949,11 @@ <h4>Removed</h4>
19491949
</ul>
19501950
<h4>Fixed</h4>
19511951
<ul>
1952+
<li>The <em>audio</em> player was no onger working since 2.1.0-fork since the play button was hidden.</li>
19521953
<li>Testing specific terms was broken (<a href="https://github.com/HugoFara/lwt/issues/66">#66</a>) and tests were sometimes not counting score. Solution inspired from PR <a href="https://github.com/HugoFara/lwt/issues/67">#67</a> from <a href="https://github.com/jzohrab">@jzohrab</a>.</li>
1953-
<li>Right frames should hide automatically but they often don't <a href="https://github.com/HugoFara/lwt/issues/61">#61</a>. Merge PR (#62)[https://github.com/HugoFara/lwt/pull/62].
1954+
<li>Right frames should hide automatically but they often don't (<a href="https://github.com/HugoFara/lwt/issues/61">#61</a>). Merged PR (#62)[https://github.com/HugoFara/lwt/pull/62].
19541955
<ul>
1955-
<li>You should also see less annoying console messages of "cClick" crashing.</li>
1956+
<li>You should no longer see annoying console messages of "cClick" crashing on "obj is null".</li>
19561957
</ul>
19571958
</li>
19581959
<li>Save text position (<code>inc/ajax_save_text_position.php</code>) was broken for all texts. This is fixed.</li>
@@ -1972,7 +1973,6 @@ <h4>Fixed</h4>
19721973
<li>POST requests are now again the default way to use it.</li>
19731974
</ul>
19741975
</li>
1975-
<li>Removed the last JS error messages of "obj is null" when calling <code>cClick</code>.</li>
19761976
<li>Sometimes tests were loop-reloading clicking after setting new status, this is fixed.</li>
19771977
</ul>
19781978
<h3>2.5.3-fork (November 06 2022)</h3>

‎src/css/jplayer.css‎

Lines changed: 19 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -72,17 +72,17 @@ div.jp-audio div.jp-type-playlist a.jp-pause {
7272
left:10px; /* 48 */
7373
}
7474
a.jp-play {
75-
background: url("./images/jplayer.blue.monday.jpg") 0 0 no-repeat;
75+
background: url("../../css/images/jplayer.blue.monday.jpg") 0 0 no-repeat;
7676
}
7777
a.jp-play:hover {
78-
background: url("./images/jplayer.blue.monday.jpg") -41px 0 no-repeat;
78+
background: url("../../css/images/jplayer.blue.monday.jpg") -41px 0 no-repeat;
7979
}
8080
a.jp-pause {
81-
background: url("./images/jplayer.blue.monday.jpg") 0 -42px no-repeat;
81+
background: url("../../css/images/jplayer.blue.monday.jpg") 0 -42px no-repeat;
8282
display: none;
8383
}
8484
a.jp-pause:hover {
85-
background: url("./images/jplayer.blue.monday.jpg") -41px -42px no-repeat;
85+
background: url("../../css/images/jplayer.blue.monday.jpg") -41px -42px no-repeat;
8686
}
8787
div.jp-audio div.jp-type-single a.jp-stop {
8888
top:11px;
@@ -93,37 +93,37 @@ div.jp-audio div.jp-type-playlist a.jp-stop {
9393
left:88px; /* 90 */
9494
}
9595
a.jp-stop {
96-
background: url("./images/jplayer.blue.monday.jpg") 0 -83px no-repeat;
96+
background: url("../../css/images/jplayer.blue.monday.jpg") 0 -83px no-repeat;
9797
width:28px;
9898
height:28px;
9999
z-index:1;
100100
}
101101
a.jp-stop:hover {
102-
background: url("./images/jplayer.blue.monday.jpg") -29px -83px no-repeat;
102+
background: url("../../css/images/jplayer.blue.monday.jpg") -29px -83px no-repeat;
103103
}
104104
div.jp-audio div.jp-type-playlist a.jp-previous {
105105
left:20px;
106106
top:26px;
107107
}
108108
a.jp-previous {
109-
background: url("./images/jplayer.blue.monday.jpg") 0 -112px no-repeat;
109+
background: url("../../css/images/jplayer.blue.monday.jpg") 0 -112px no-repeat;
110110
width:28px;
111111
height:28px;
112112
}
113113
a.jp-previous:hover {
114-
background: url("./images/jplayer.blue.monday.jpg") -29px -112px no-repeat;
114+
background: url("../../css/images/jplayer.blue.monday.jpg") -29px -112px no-repeat;
115115
}
116116
div.jp-audio div.jp-type-playlist a.jp-next {
117117
left:88px;
118118
top:26px;
119119
}
120120
a.jp-next {
121-
background: url("./images/jplayer.blue.monday.jpg") 0 -141px no-repeat;
121+
background: url("../../css/images/jplayer.blue.monday.jpg") 0 -141px no-repeat;
122122
width:28px;
123123
height:28px;
124124
}
125125
a.jp-next:hover {
126-
background: url("./images/jplayer.blue.monday.jpg") -29px -141px no-repeat;
126+
background: url("../../css/images/jplayer.blue.monday.jpg") -29px -141px no-repeat;
127127
}
128128
div.jp-progress {
129129
position: absolute;
@@ -143,18 +143,18 @@ div.jp-audio div.jp-type-playlist div.jp-progress {
143143
height:15px;
144144
}
145145
div.jp-seek-bar {
146-
background: url("./images/jplayer.blue.monday.jpg") 0 -202px repeat-x;
146+
background: url("../../css/images/jplayer.blue.monday.jpg") 0 -202px repeat-x;
147147
width:0px;
148148
height:100%;
149149
cursor: pointer;
150150
}
151151
div.jp-play-bar {
152-
background: url("./images/jplayer.blue.monday.jpg") 0 -218px repeat-x ;
152+
background: url("../../css/images/jplayer.blue.monday.jpg") 0 -218px repeat-x ;
153153
width:0px;
154154
height:100%;
155155
}
156156
div.jp-seeking-bg {
157-
background: url("./images/pbar-ani.gif");
157+
background: url("../../css/images/pbar-ani.gif");
158158
}
159159
a.jp-mute,
160160
a.jp-unmute {
@@ -172,22 +172,22 @@ div.jp-audio div.jp-type-playlist a.jp-unmute {
172172
left:246px; /* 296 */
173173
}
174174
a.jp-mute {
175-
background: url("./images/jplayer.blue.monday.jpg") 0 -186px no-repeat;
175+
background: url("../../css/images/jplayer.blue.monday.jpg") 0 -186px no-repeat;
176176
}
177177
a.jp-mute:hover {
178-
background: url("./images/jplayer.blue.monday.jpg") -0.97em -186px no-repeat;
178+
background: url("../../css/images/jplayer.blue.monday.jpg") -0.97em -186px no-repeat;
179179
}
180180
a.jp-unmute {
181-
background: url("./images/jplayer.blue.monday.jpg") 0 -170px no-repeat;
181+
background: url("../../css/images/jplayer.blue.monday.jpg") 0 -170px no-repeat;
182182
display: none;
183183
}
184184
a.jp-unmute:hover {
185-
background: url("./images/jplayer.blue.monday.jpg") -0.97em -170px no-repeat;
185+
background: url("../../css/images/jplayer.blue.monday.jpg") -0.97em -170px no-repeat;
186186
}
187187
div.jp-volume-bar {
188188
position: absolute;
189189
overflow:hidden;
190-
background: url("./images/jplayer.blue.monday.jpg") 0 -202px repeat-x; /* -250 */
190+
background: url("../../css/images/jplayer.blue.monday.jpg") 0 -202px repeat-x; /* -250 */
191191
width:46px;
192192
height:10px;
193193
cursor: pointer;
@@ -201,7 +201,7 @@ div.jp-audio div.jp-type-playlist div.jp-volume-bar {
201201
left:274px; /* 324 */
202202
}
203203
div.jp-volume-bar-value {
204-
background: url("./images/jplayer.blue.monday.jpg") 0 -218px repeat-x; /* -256 */
204+
background: url("../../css/images/jplayer.blue.monday.jpg") 0 -218px repeat-x; /* -256 */
205205
width:0px;
206206
height:10px;
207207
}

0 commit comments

Comments
 (0)