Skip to content

Commit c79d6d0

Browse files
committed
Remove exceptions search by task
1 parent 0ff9c36 commit c79d6d0

3 files changed

Lines changed: 4 additions & 29 deletions

File tree

‎ProcessMaker/Http/Controllers/Api/ProcessController.php‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616
use ProcessMaker\Http\Resources\ProcessRequests;
1717
use ProcessMaker\Jobs\ExportProcess;
1818
use ProcessMaker\Jobs\ImportProcess;
19+
use ProcessMaker\Managers\ExportManager;
1920
use ProcessMaker\Models\Process;
2021
use ProcessMaker\Models\ProcessCategory;
2122
use ProcessMaker\Models\ProcessPermission;
@@ -28,6 +29,7 @@
2829
use ProcessMaker\Package\WebEntry\Models\WebentryRoute;
2930
use ProcessMaker\Providers\WorkflowServiceProvider;
3031
use ProcessMaker\Rules\BPMNValidation;
32+
use ProcessMaker\SanitizeHelper;
3133
use Throwable;
3234

3335
class ProcessController extends Controller

‎ProcessMaker/Http/Controllers/Api/TaskController.php‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -314,7 +314,7 @@ public function update(Request $request, ProcessRequestToken $task)
314314
}
315315
// Skip ConvertEmptyStringsToNull and TrimStrings middlewares
316316
$data = json_decode($request->getContent(), true);
317-
$data = SanitizeHelper::sanitizeData($data['data'], $task);
317+
$data = SanitizeHelper::sanitizeData($data['data'], $task->processRequest->do_not_sanitize);
318318
//Call the manager to trigger the start event
319319
$process = $task->process;
320320
$instance = $task->processRequest;

‎ProcessMaker/SanitizeHelper.php‎

Lines changed: 1 addition & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -99,35 +99,8 @@ private static function convertTagToRegExp($tag)
9999
*
100100
* @return string
101101
*/
102-
public static function sanitizeData($data, $task)
102+
public static function sanitizeData($data, $except = [])
103103
{
104-
// Get current and nested screens IDs ..
105-
$currentScreenExceptions = [];
106-
$currentScreenAndNestedIds = $task->getScreenAndNestedIds();
107-
foreach ($currentScreenAndNestedIds as $id) {
108-
// Find the screen version ..
109-
$screen = Screen::findOrFail($id);
110-
$screen = $screen->versionFor($task->processRequest)->toArray();
111-
// Get exceptions ..
112-
$exceptions = self::getExceptions((object) $screen);
113-
if (count($exceptions)) {
114-
$currentScreenExceptions = array_unique(array_merge($exceptions, $currentScreenExceptions));
115-
}
116-
}
117-
118-
// Get process request exceptions stored in do_not_sanitize column ..
119-
$processRequestExceptions = $task->processRequest->do_not_sanitize;
120-
if (!$processRequestExceptions) {
121-
$processRequestExceptions = [];
122-
}
123-
124-
// Merge (nestedSreensExceptions and currentScreenExceptions) with processRequestExceptions ..
125-
$except = array_unique(array_merge($processRequestExceptions, $currentScreenExceptions));
126-
127-
// Update database with all the exceptions ..
128-
$task->processRequest->do_not_sanitize = $except;
129-
$task->processRequest->save();
130-
131104
return self::sanitizeWithExceptions($data, $except);
132105
}
133106

0 commit comments

Comments
 (0)