Skip to content

Commit 45f052d

Browse files
committed
Sonarqube fixes
1 parent 720d831 commit 45f052d

3 files changed

Lines changed: 11 additions & 7 deletions

File tree

‎ProcessMaker/Http/Controllers/RequestController.php‎

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,10 @@ public function index($type = null)
7070
SavedSearch::KEY_REQUESTS,
7171
);
7272
if ($defaultSavedSearch) {
73-
$defaultColumns = SavedSearchController::adjustColumnsOf($defaultSavedSearch->columns, SavedSearch::TYPE_REQUEST);
73+
$defaultColumns = SavedSearchController::adjustColumnsOf(
74+
$defaultSavedSearch->columns,
75+
SavedSearch::TYPE_REQUEST
76+
);
7477
} else {
7578
$defaultColumns = null;
7679
}

‎ProcessMaker/Http/Controllers/TaskController.php‎

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,10 @@ public function index()
5252
SavedSearch::KEY_TASKS,
5353
);
5454
if ($defaultSavedSearch) {
55-
$defaultColumns = SavedSearchController::adjustColumnsOf($defaultSavedSearch->columns, SavedSearch::TYPE_TASK);
55+
$defaultColumns = SavedSearchController::adjustColumnsOf(
56+
$defaultSavedSearch->columns,
57+
SavedSearch::TYPE_TASK
58+
);
5659
} else {
5760
$defaultColumns = null;
5861
}

‎resources/js/common/setDefaultAdvancedFilterStatus.js‎

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -5,11 +5,9 @@ export default (status, ignoreSavedFilter = false) => {
55
if (ignoreSavedFilter) {
66
// Remove any Status filters that might be set by the user
77
advancedFilter = advancedFilter.filter(f => f.subject?.type !== "Status");
8-
} else {
9-
if (advancedFilter.some(f => f.subject?.type === "Status")) {
10-
// Already has a status filter set by the user
11-
return;
12-
}
8+
} else if (advancedFilter.some(f => f.subject?.type === "Status")) {
9+
// Already has a status filter set by the user
10+
return;
1311
}
1412
advancedFilter.push({
1513
subject: {

0 commit comments

Comments
 (0)