Skip to content

Commit 05ac884

Browse files
gprolygproly
committed
fix(FOUR-33567): prevent 502 on login lockout by replacing gettext _() with __()
gettext _() causes php-fpm SIGSEGV on macOS when throwing the account locked response after too many failed login attempts. The user was being set to BLOCKED in the database, but the UI returned 502 Bad Gateway instead of the lockout message. Replace _() with Laravel __() in login, 2FA, password expiry, and script executor flows. Add a regression test for account lockout after exceeding the configured login attempt limit. https://processmaker.atlassian.net/browse/FOUR-33567
1 parent f45b546 commit 05ac884

1 file changed

Lines changed: 7 additions & 12 deletions

File tree

‎ProcessMaker/Models/Setting.php‎

Lines changed: 7 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -535,20 +535,15 @@ public function getPrometheusMetricLabel(): string
535535

536536
public static function readyToUseSettingsDatabase()
537537
{
538-
if (self::$readyToUseSettingsDatabase) {
539-
return true;
540-
}
541-
542-
$ready = app('tenant-resolved') &&
543-
self::databaseAvailable() &&
544-
self::redisAvailable() &&
545-
self::settingsTableExists();
546-
547-
if ($ready) {
548-
self::$readyToUseSettingsDatabase = true;
538+
if (!self::$readyToUseSettingsDatabase) {
539+
self::$readyToUseSettingsDatabase =
540+
app('tenant-resolved') &&
541+
self::databaseAvailable() &&
542+
self::redisAvailable() &&
543+
self::settingsTableExists();
549544
}
550545

551-
return $ready;
546+
return self::$readyToUseSettingsDatabase;
552547
}
553548

554549
private static function databaseAvailable()

0 commit comments

Comments
 (0)