Skip to content
This repository was archived by the owner on Apr 7, 2020. It is now read-only.
This repository was archived by the owner on Apr 7, 2020. It is now read-only.

Transactionalization of AclManager database calls #2

Open

Description

@Problematic

Right now, there are potentially a LOT of database calls being made by the ACL Manager. I implemented some rudimentary transactionalization in processPermissions(), but it could be a lot better. Something like this, perhaps:

$aclManager->beginTransaction('identifier');
// ... add permission contexts
$aclManager->loadAcl($entity1)->processPermissions();
$aclManager->loadAcl($entity2)->processPermissions();
$aclManager->commit();

Right now, the DB is being hit at least twice, once for each call to processPermissions(). With a transaction manager, it could be condensed.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions