Skip to content

Removed direct usages of causally related to property - #2110

Merged
stap-m merged 3 commits into
devfrom
feature-2105-remove-causally_related_to-usage
Sep 24, 2025
Merged

Removed direct usages of causally related to property#2110
stap-m merged 3 commits into
devfrom
feature-2105-remove-causally_related_to-usage

Conversation

@ColinHDev

@ColinHDev ColinHDev commented Jul 12, 2025

Copy link
Copy Markdown
Member

Summary of the discussion

As discussed in #2105, the RO property causally related to shouldn't be used directly.

Type of change (CHANGELOG.md)

Update

  • export, import, distribution
    • changed the subclass axiom 'causally related to' some 'service' to 'causally upstream of or within' some 'service'

Workflow checklist

Automation

Closes #2105

PR-Assignee

Reviewer

  • 🐙 Follow the Reviewer Guide
  • 🐙 Provided feedback and show sufficient appreciation for the work done

@stap-m stap-m added this to Issues Jul 12, 2025
@github-actions github-actions Bot added oeo-shared-axioms oeo-social changes the oeo-social module labels Jul 12, 2025
@github-project-automation github-project-automation Bot moved this to Review in progress in Issues Jul 12, 2025
@ColinHDev
ColinHDev requested a review from stap-m July 12, 2025 14:00
@ColinHDev

ColinHDev commented Jul 12, 2025

Copy link
Copy Markdown
Member Author

Should this small change also be mentioned in the changelog and term tracker annotation?

@stap-m

stap-m commented Jul 22, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Yes, at least term tracker annotations please.
I just saw, that you made changes in oeo-shared-axioms, and I'm wondering why.
EDIT: The changes for im/export should be done in oeo-shared.omn instead of oeo-shared-axioms. These are two different files...

@ColinHDev

ColinHDev commented Jul 27, 2025

Copy link
Copy Markdown
Member Author

EDIT: The changes for im/export should be done in oeo-shared.omn instead of oeo-shared-axioms. These are two different files...

Looks like their axioms were previously declared to be in oeo-shared-axioms. So I should move them in this pr to oeo-shared?

@madbkr

madbkr commented Sep 15, 2025

Copy link
Copy Markdown
Contributor

Content wise I feel like import and export do belong to oeo-shared instead of shared-axioms because they are new entities. So I thing yes, they should be moved. Maybe @stap-m can give a thumbs up?

@stap-m

stap-m commented Sep 24, 2025

Copy link
Copy Markdown
Contributor

Sorry @ColinHDev you were right. Since import/export live in oeo-shared and service lives in oeo-social, the axiom belongs to oeo-shared-axioms.

@github-project-automation github-project-automation Bot moved this from Review in progress to Reviewer approved in Issues Sep 24, 2025
@stap-m
stap-m merged commit 4f3a9dc into dev Sep 24, 2025
3 checks passed
@github-project-automation github-project-automation Bot moved this from Reviewer approved to Done in Issues Sep 24, 2025
@stap-m
stap-m deleted the feature-2105-remove-causally_related_to-usage branch September 24, 2025 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stap-m stap-m stap-m approved these changes

Assignees

No one assigned

Labels

oeo-shared-axioms oeo-social changes the oeo-social module

Projects

Issues
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

causally related to property shouldn't be used directly

3 participants

@ColinHDev @stap-m @madbkr