nuitka is incompatible with overrides

(Cross-posted from mkorpela/overrides#111 since I have no idea which instance may be best able to fix it.)

This code runs find in python but not after building with nuitka 1.4.4 on Python 3.10:

"""bug.py"""
from overrides import override

class A:
    def hello(self) -> None:
        print("A")

class B(A):
    @override
    def hello(self) -> None:
        print("B")

b = B()
b.hello()

$ pip install nuitka overrides
$ python bug.py
B
$ python -m nuitka bug.py
...
Nuitka:INFO: Successfully created 'bug.bin'.
$ ./bug.bin
Traceback (most recent call last):
  File "/mnt/c/code/bug.py", line 8, in <module>
    class B(A):
  File "/mnt/c/code/bug.py", line 9, in B
    @override
  File "/home/bers/.local/lib/python3.10/site-packages/overrides/overrides.py", line 143, in override
    return _overrides(method, check_signature, check_at_runtime)
  File "/home/bers/.local/lib/python3.10/site-packages/overrides/overrides.py", line 172, in _overrides
    raise TypeError(f"{method.__qualname__}: No super class method found")
TypeError: B.hello: No super class method found

It seems the overrides packages parses byte code, which is really hard when there is no such thing. I find it confusing why it would do that. At least in your example, that seems unnecessary. It appears it would allow to see assignments that will be done later.

Now it will be an interesting puzzle to solve this. Effectively, _get_base_class_names(frame) would have to be executed at compile time, and then at run time, where to code object, say qualname would have to be a key, into a dictionary with the identifiers.

However, outside of Nuitka commercial I do not see myself doing this for a while. With somebody willing to pay my time there, no problem, but right now there is more important stuff to do otherwise.

No problem at all! I can easily fallback by such a construct here:

if whatever:
    from overrides import override
else:
    F = TypeVar("F", bound=Callable)
    def override(method: F) -> F:
        return method

Is there an ideal way to check that my code has been/is being compiled by Nuitka? PyInstaller defines sys.frozen, for instance: https://pyinstaller.org/en/stable/runtime-information.html

This looks then more like something the anti-bloat engine could do instead. Just replace @override with empty string. Check out this: https://nuitka.net/posts/nuitka-package-config-kickoff.html

If that is functionality equivalent (I think doc strings will not be copied), then we can get away with that and call it a day. Will you create a PR?

This looks like a good solution, too - I'll keep that in mind.

In the meantime, I think I found a good fix to @override myself (compare mkorpela/overrides#112), so maybe it's not even required to add overrides to Nuitkas list of bad-behavers. I'll see if my proposed change can be considered for override.

Yes, we can do that, or even replace the whole function. You can experiment with this:

- module-name: 'overrides'
  anti-bloat:
    - description: 'disable overrides function checking'
      replacements:
      change_function:
        'overrides': "'(lambda fn: fn)'"

I will try that later, just replaces the whole function with that lambda. We do similar for other software I took this from 'tensorflow.python.ops.distributions.distribution' configuration.

I feel that's probably already the solution and of course could be in a next hotfix once confirmed.

Alright, will check tomorrow. Not sure yet if we need to change overrides.override, overrides.overrides, or both. Compare mkorpela/overrides@5d67cab

I'm not at all sure should I merge the PR to overrides mkorpela/overrides#112 it basically silently just fails the whole operation.

It seems the overrides packages parses byte code, which is really hard when there is no such thing. I find it confusing why it would do that.

Because it checks override during class loading and that is the place where the super class is found from.
How would that (checking method override) work in case of a pre-compiled language?

I know that Python 3.12 will have a override decorator in types https://peps.python.org/pep-0698/

I'm not at all sure should I merge the PR to overrides mkorpela/overrides#112 it basically silently just fails the whole operation.

I agree - would it help if we made the check more specific? I noticed that dis.get_instructions(frame.f_code) returns an empty iterator, but I assume one may go a bit further still to find a specific indication that there is no byte code.

How would that (checking method override) would work in case of a pre-compiled language?

No idea, unfortunately.

I know that Python 3.12 will have a override decorator in types https://peps.python.org/pep-0698/

Interesting, thank you! Maybe Nuitka can (has to?) consider that one as well, and in effect consider both overrides.override and the new typing.override in one.

@mkorpela

For the record, it will be in Python 3.12 via python/cpython#101564. Until then it is also available via python/typing_extensions#78. Since that "official" decorator is defined to not have any runtime effects, I would guess Nuitka does not have to care about either of those.

Whether Nuitka will need to support overrides certainly depends on what @mkorpela's plans are. @mkorpela, will you keep maintaining it to offer runtime checks, or will you deprecate? To be honest, I will probably switch from overrides to typing(_extensions) once mypy supports it (python/mypy#14072), because it means one less dependency and I am happy with mypy reporting override errors.

For whatever feature is added to Python, there is always a backport available, that Nuitka gets to support. I doubt it will be different in this case, otherwise the feature will be unavailable for use in practically all libraries.

For whatever feature is added to Python, there is always a backport available, that Nuitka gets to support.

I understand that.

I doubt it will be different in this case, otherwise the feature will be unavailable for use in practically all libraries.

Well, what is different in this case is that, as I wrote, @override is defined to not have runtime effects, so Nuitka would not need to support any. I just checked, and this code runs fine after compilation with Nuitka:

from typing_extensions import override

class BaseClass:
    def hello(self) -> None:
        print(self)

class Class(BaseClass):
    @override
    def hello(self) -> None:
        print(self)

c = Class()
c.hello()

That's good. For that overrides package there is a fix on factory branch now. The typing_extensions are also a backport, are they, or just another implementation of the same thing, that will be in typing in the future?

That's good. For that overrides package there is a fix on factory branch now.

Great!

The typing_extensions are also a backport, are they, or just another implementation of the same thing, that will be in typing in the future?

Not sure I understand the difference to be honest. I'd say both, I guess. Check these two links for current implementations:

https://github.com/python/cpython/pull/101564/files#diff-ddb987fca5f5df0c9a2f5521ed687919d70bb3d64eaeb8021f98833a2a716887R3458-R3491

https://github.com/python/typing_extensions/blob/e81cb8289874d6a6715675d77df88db033824e0d/src/typing_extensions.py#L2093-L2131

I had to make a hotfix the other day, and the change is actually part of 1.4.6 because it's only config.

Navigation Menu

Repository navigation

`nuitka` is incompatible with `overrides` #2048

4 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

nuitka is incompatible with overrides #2048

Description

Activity

kayhayen commented on Feb 10, 2023

bersbersbers commented on Feb 10, 2023

kayhayen commented on Feb 10, 2023

bersbersbers commented on Feb 10, 2023

kayhayen commented on Feb 11, 2023

kayhayen commented on Feb 11, 2023

bersbersbers commented on Feb 11, 2023

4 remaining items

mkorpela commented on Feb 12, 2023

bersbersbers commented on Feb 12, 2023

bersbersbers commented on Feb 12, 2023

kayhayen commented on Feb 12, 2023

bersbersbers commented on Feb 12, 2023

kayhayen commented on Feb 12, 2023

bersbersbers commented on Feb 12, 2023

kayhayen commented on Feb 13, 2023

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions

`nuitka` is incompatible with `overrides` #2048