Skip to content

[DOC] Add steps for running tests on Windows #862

Open

Description

@gmarkall

The documentation for running tests in the readme only describes the process on Linux.

We should also add the equivalent steps for running tests on Windows.

Activity

  1. added
    docImprovements or additions to documentation
    on Apr 17, 2026
  2. added this to the numba-cuda next milestone on Apr 17, 2026
  3. acosmicflamingo commented on May 14, 2026

    @acosmicflamingo

    Before writing the equivalent documentation for Windows, perhaps the first thing to discuss is whether we want to require users to have a Windows-equivalent make installed or whether we should maintain a separate Makefile.win for them.

    The latter will certainly be more beneficial for Windows users since we don't have to require them to install yet another dependency. But, if most (if not all) numba-cuda users on the Windows platform already have a Windows-equivalent make installed (e.g. msys2, cygwin, etc.), then perhaps this is a win for maintainability since now we just have to worry about updating one single Makefile.

  4. omribz156 commented on May 27, 2026

    @omribz156

    I can take a focused pass on this. I’ll keep it docs-only and add Windows-native test-running steps without introducing a separate Windows Makefile unless the existing repo docs/source clearly point that way.

    This will be Codex-assisted, and I’ll manually review the final patch before opening a PR.

  5. acosmicflamingo commented on May 27, 2026

    @acosmicflamingo

    @omribz156 so that build.bat script was called by ci/test_wheel.ps1 a few months ago in this PR, and it was the only thing referencing build.bat before it was removed from the codebase. Additionally, it doesn't look like it was getting as many updates as Makefile currently does. With that being said, before giving build.bat a well-needed makeover, I think we first need to know whether we are better off maintaining two distinct files, or whether we should leverage unix-tools in Windows so we can just use Makefile. That's actually why I asked my original question above :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    docImprovements or additions to documentation

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions