Skip to content

Commit b5e0223

Browse files
electron-roller[bot]jkleinscclaude
authored and
KanishkRanjan
committed
chore: bump node to v24.16.0 (main) (electron#51749)
* chore: bump node in DEPS to v24.16.0 * fix(patch): adapt GetIsolate removal for network_agent.cc refactor Upstream moved the static Object* helpers out of network_agent.cc into the new src/inspector/inspector_object_utils.{h,cc} and converted the existing methods to NetworkAgent member functions. Update the patch so the deprecated v8::Context::GetIsolate() removal applies to the new member methods that obtain the isolate via env_->isolate(). Ref: nodejs/node#61139 Co-Authored-By: Claude <noreply@anthropic.com> * chore: remove upstreamed patch Node.js restored fs patchability in the ESM loader upstream, making the fix_lazyload_fs_in_esm_loaders_to_apply_asar_patches.patch obsolete (the patch's exact change is now in lib/internal/modules/ esm/{load,resolve,translators}.js). Ref: nodejs/node#62835 Co-Authored-By: Claude <noreply@anthropic.com> * chore: update patches (trivial only) Co-Authored-By: Claude <noreply@anthropic.com> * fix(patch): re-add experimental_fetch member after upstream cleanup Upstream removed the experimental_fetch field from EnvironmentOptions, but Electron's patch still registers --experimental-fetch as a CLI option bound to that field. Re-add the member so the option compiles. Ref: nodejs/node#62759 Co-Authored-By: Claude <noreply@anthropic.com> * fix(patch): cast const away when freeing uv_cpu_info_t.model libuv 1.52.1 typed uv_cpu_info_t.model as const char*, but uv__free takes void*. Electron builds with -Werror,-Wincompatible-pointer-types- discards-qualifiers, so add a cast. The memory is allocated via strdup so the cast is safe. Ref: nodejs/node#61829 Co-Authored-By: Claude <noreply@anthropic.com> * fix(patch): silence sign-compare warning in sessionVarintGetSafe Cast int nBuf to size_t when comparing with sizeof(aCopy) so the bundled sqlite3 amalgamation compiles under -Werror,-Wsign-compare. Ref: Unable to locate reference Co-Authored-By: Claude <noreply@anthropic.com> * test: move root package.json aside in node spec runner third_party/electron_node lives under Chromium's src/, whose package.json ("type": "module") is always an ancestor of the Node.js test tree. Upstream assumes no package.json sits above the tests, so that ancestor changes how test files and fixtures resolve their module type: it disables module-syntax detection (breaking test-compile-cache-typescript-esm) and emits MODULE_TYPELESS_PACKAGE_JSON warnings that break tests asserting clean stderr (test-esm-detect-ambiguous, test-esm-import-meta-main-eval, test-output-coverage-with-mock). Move src/package.json aside for the duration of the run so the environment matches upstream exactly, then restore it. The original is kept in a sibling backup file so an interrupted/killed run self-heals on the next invocation rather than leaving src/package.json missing. Ref: Unable to locate reference Co-Authored-By: Claude <noreply@anthropic.com> * chore: regenerate filenames.auto.gni for v24.16.0 headers New inspector/node headers added in Node.js v24.16.0 were missing from the auto-generated source list. Ref: Unable to locate reference Co-Authored-By: Claude <noreply@anthropic.com> * fix(patch): mark test-macos-app-sandbox as flaky The test copies the Electron binary into a standalone .app bundle and code-signs it; under parallel suite runs this races with dyld resolving the Electron Framework rpath and intermittently aborts (SIGABRT). It passes reliably when run alone. Mark it flaky so flakes don't fail CI. Ref: Unable to locate reference Co-Authored-By: Claude <noreply@anthropic.com> * test: disable test-tls-set-default-ca-certificates-extra-override setDefaultCACertificates() round-trips the default CA set through BoringSSL's X509_STORE, which dedups a duplicate-subject root (DigiCert Global Root CA) that OpenSSL keeps. The set therefore loses one cert on re-add (149 -> 148), so the test's assertEqualCerts round-trip check fails under Electron's BoringSSL. The sibling -recovery test is disabled for the same reason. Ref: nodejs/node#58822 Co-Authored-By: Claude <noreply@anthropic.com> * fix(patch): mark test-runner watch tests as flaky test-run-watch-repeatedly, test-run-watch-run-duration and test-run-watch-without-file race under parallel suite load: the watcher fires an extra re-run before the assertion, so the expected single-run output ("tests 1") arrives with accumulated subtests. All three pass in isolation. Ref: nodejs/node#44898 Co-Authored-By: Claude <noreply@anthropic.com> * chore: update patches * chore(patches): update libuv const-cast patch management Combine the Windows libuv cpu_info const-cast update into the existing chore_cast_const_away_when_freeing_uv_cpu_info_t_model.patch and keep a single patch-management commit for the final exported patch series. Co-Authored-By: Claude <noreply@anthropic.com> --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: John Kleinschmidt <kleinschmidtorama@gmail.com> Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
1 parent 8712a6a commit b5e0223

43 files changed

Lines changed: 387 additions & 413 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎DEPS‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ vars = {
44
'chromium_version':
55
'150.0.7863.0',
66
'node_version':
7-
'v24.15.0',
7+
'v24.16.0',
88
'nan_version':
99
'675cefebca42410733da8a454c8d9391fcebfbc2',
1010
'squirrel.mac_version':

‎filenames.auto.gni‎

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -246,6 +246,8 @@ auto_filenames = {
246246
"../third_party/electron_node/src/handle_wrap.h",
247247
"../third_party/electron_node/src/histogram-inl.h",
248248
"../third_party/electron_node/src/histogram.h",
249+
"../third_party/electron_node/src/inspector/dom_storage_agent.h",
250+
"../third_party/electron_node/src/inspector/inspector_object_utils.h",
249251
"../third_party/electron_node/src/inspector/io_agent.h",
250252
"../third_party/electron_node/src/inspector/main_thread_interface.h",
251253
"../third_party/electron_node/src/inspector/network_agent.h",
@@ -254,8 +256,10 @@ auto_filenames = {
254256
"../third_party/electron_node/src/inspector/network_resource_manager.h",
255257
"../third_party/electron_node/src/inspector/node_json.h",
256258
"../third_party/electron_node/src/inspector/node_string.h",
259+
"../third_party/electron_node/src/inspector/notification_emitter.h",
257260
"../third_party/electron_node/src/inspector/protocol_helper.h",
258261
"../third_party/electron_node/src/inspector/runtime_agent.h",
262+
"../third_party/electron_node/src/inspector/storage_agent.h",
259263
"../third_party/electron_node/src/inspector/target_agent.h",
260264
"../third_party/electron_node/src/inspector/target_manager.h",
261265
"../third_party/electron_node/src/inspector/tracing_agent.h",
@@ -301,6 +305,7 @@ auto_filenames = {
301305
"../third_party/electron_node/src/node_external_reference.h",
302306
"../third_party/electron_node/src/node_file-inl.h",
303307
"../third_party/electron_node/src/node_file.h",
308+
"../third_party/electron_node/src/node_hash.h",
304309
"../third_party/electron_node/src/node_http2.h",
305310
"../third_party/electron_node/src/node_http2_state.h",
306311
"../third_party/electron_node/src/node_http_common-inl.h",
@@ -361,11 +366,13 @@ auto_filenames = {
361366
"../third_party/electron_node/src/permission/worker_permission.h",
362367
"../third_party/electron_node/src/pipe_wrap.h",
363368
"../third_party/electron_node/src/quic/application.h",
369+
"../third_party/electron_node/src/quic/arena.h",
364370
"../third_party/electron_node/src/quic/bindingdata.h",
365371
"../third_party/electron_node/src/quic/cid.h",
366372
"../third_party/electron_node/src/quic/data.h",
367373
"../third_party/electron_node/src/quic/defs.h",
368374
"../third_party/electron_node/src/quic/endpoint.h",
375+
"../third_party/electron_node/src/quic/guard.h",
369376
"../third_party/electron_node/src/quic/http3.h",
370377
"../third_party/electron_node/src/quic/logstream.h",
371378
"../third_party/electron_node/src/quic/packet.h",

‎patches/node/.patches‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@ support_v8_sandboxed_pointers.patch
1212
build_ensure_native_module_compilation_fails_if_not_using_a_new.patch
1313
fix_expose_the_built-in_electron_module_via_the_esm_loader.patch
1414
enable_crashpad_linux_node_processes.patch
15-
fix_lazyload_fs_in_esm_loaders_to_apply_asar_patches.patch
1615
chore_expose_importmoduledynamically_and.patch
1716
test_formally_mark_some_tests_as_flaky.patch
1817
fix_do_not_resolve_electron_entrypoints.patch
@@ -50,3 +49,5 @@ fix_add_missing_cstdlib_include_to_builtin_info.patch
5049
electron_build-time_v8_code_cache_for_the_electron_js2c_bundles.patch
5150
electron_enable_node_startup_snapshot_generation_in_chromium_s_v8.patch
5251
fix_preserve_node_symbols_and_vtables_under_thinlto.patch
52+
chore_cast_const_away_when_freeing_uv_cpu_info_t_model.patch
53+
chore_silence_sign-compare_warning_in_sessionvarintgetsafe.patch

‎patches/node/api_delete_deprecated_fields_on_v8_isolate.patch‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ Subject: Delete deprecated fields on v8::Isolate
66
https://chromium-review.googlesource.com/c/v8/v8/+/7081397
77

88
diff --git a/src/api/environment.cc b/src/api/environment.cc
9-
index 6873a9f203ccace7d5c501b62bed56732332d060..7ba7943c666d9cf3de47bf9a18b8e6e0e1196886 100644
9+
index dd0100693afdabaf8d7bae25dccee237b3c0a5c2..31199141b71ebe05c1171476fdef50cb0cad110e 100644
1010
--- a/src/api/environment.cc
1111
+++ b/src/api/environment.cc
1212
@@ -218,8 +218,6 @@ void SetIsolateCreateParamsForNode(Isolate::CreateParams* params) {

‎patches/node/api_remove_deprecated_getisolate.patch‎

Lines changed: 70 additions & 140 deletions
Large diffs are not rendered by default.

‎patches/node/build_add_gn_build_files.patch‎

Lines changed: 6 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -15,10 +15,10 @@ was missing gypi_values.node_pdl_files from its inputs, causing Ninja to skip
1515
regeneration when PDL domain files changed. Should be upstreamed.
1616

1717
diff --git a/configure.py b/configure.py
18-
index fa25de8c316b71d3ad5b55b5ce398b69a5d4a965..fc48438060e0dd84edc60d1aebf3d0946be98ea9 100755
18+
index e05c11611052373bd74cf2f4fb1fdb7b1cf24e77..8f101999c20ef9d59d96d507b403f13cf9f23ae8 100755
1919
--- a/configure.py
2020
+++ b/configure.py
21-
@@ -1838,7 +1838,7 @@ def configure_v8(o, configs):
21+
@@ -1897,7 +1897,7 @@ def configure_v8(o, configs):
2222
# Until we manage to get rid of all those, v8_enable_sandbox cannot be used.
2323
# Note that enabling pointer compression without enabling sandbox is unsupported by V8,
2424
# so this can be broken at any time.
@@ -71,24 +71,11 @@ index 41f200189a34e150e4c8f25da2a72c2108259720..156fee33b3813fe4d94a1c9585f217a9
7171
}
7272

7373
assert(!node_enable_inspector || node_use_openssl,
74-
diff --git a/src/inspector/unofficial.gni b/src/inspector/unofficial.gni
75-
index 4810d93eb971b253f7dadff7011a632f6dbe6a2b..48cf5102630737ffeba98719a8b508b52fe5e27a 100644
76-
--- a/src/inspector/unofficial.gni
77-
+++ b/src/inspector/unofficial.gni
78-
@@ -29,7 +29,7 @@ template("inspector_gn_build") {
79-
deps = [ ":node_protocol_json" ]
80-
81-
outputs = gypi_values.node_inspector_generated_sources
82-
- inputs = gypi_values.node_protocol_files + [
83-
+ inputs = gypi_values.node_protocol_files + gypi_values.node_pdl_files + [
84-
"node_protocol_config.json",
85-
"$node_gen_dir/src/node_protocol.json",
86-
]
8774
diff --git a/src/node_builtins.cc b/src/node_builtins.cc
88-
index 6506dcea3f4f88a7781975fae1ee5f8b87d4dfb2..a077ad673fdf7eab61878940e5fef43921c2e453 100644
75+
index 70c628294c98d79d2eb1a5e519f50113f42e4d8e..edcf2d8424f9b60d68ddd95b16da488feec2c41b 100644
8976
--- a/src/node_builtins.cc
9077
+++ b/src/node_builtins.cc
91-
@@ -455,6 +455,30 @@ MaybeLocal<Function> BuiltinLoader::LookupAndCompileFunction(
78+
@@ -458,6 +458,30 @@ MaybeLocal<Function> BuiltinLoader::LookupAndCompileFunction(
9279
return value.As<Function>();
9380
}
9481

@@ -119,7 +106,7 @@ index 6506dcea3f4f88a7781975fae1ee5f8b87d4dfb2..a077ad673fdf7eab61878940e5fef439
119106
MaybeLocal<Value> BuiltinLoader::CompileAndCall(Local<Context> context,
120107
const char* id,
121108
Realm* realm) {
122-
@@ -741,7 +765,7 @@ MaybeLocal<Module> BuiltinLoader::LoadBuiltinSourceTextModule(Realm* realm,
109+
@@ -744,7 +768,7 @@ MaybeLocal<Module> BuiltinLoader::LoadBuiltinSourceTextModule(Realm* realm,
123110
// Pre-fetch all dependencies.
124111
if (requests->Length() > 0) {
125112
for (int i = 0; i < requests->Length(); i++) {
@@ -128,7 +115,7 @@ index 6506dcea3f4f88a7781975fae1ee5f8b87d4dfb2..a077ad673fdf7eab61878940e5fef439
128115
std::string specifier =
129116
Utf8Value(isolate, req->GetSpecifier()).ToString();
130117
std::string resolved_id = ResolveRequestForBuiltin(specifier);
131-
@@ -900,6 +924,7 @@ void BuiltinLoader::RegisterExternalReferences(
118+
@@ -903,6 +927,7 @@ void BuiltinLoader::RegisterExternalReferences(
132119
registry->Register(ImportBuiltinSourceTextModule);
133120

134121
RegisterExternalReferencesForInternalizedBuiltinCode(registry);

‎patches/node/build_enable_perfetto.patch‎

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ index 8d7204f6cb48f783adc4d1c1eb2de0c83b7fffe2..8061013fcfe3c3b02aabaca044706942
2828

2929
// Non-alphabetic chars.
3030
diff --git a/lib/internal/http.js b/lib/internal/http.js
31-
index f8b4fd7c4ca5a0907806c7e804de8c951675a36a..0f924a5cc6718415226ffef5f8bc40a51043be04 100644
31+
index 54f1121eb712c089dfced2a0aaa49aa875341f3c..592964bdc28400765026eafcdb137bfc9e1222b4 100644
3232
--- a/lib/internal/http.js
3333
+++ b/lib/internal/http.js
3434
@@ -9,7 +9,7 @@ const {
@@ -168,10 +168,10 @@ index 06a4f8a239855571dcc67cd81e7da7a255a9ebfd..1fa9e314ad796cdf74f718f0eb2a1553
168168
}
169169

170170
diff --git a/node.gyp b/node.gyp
171-
index 0620850e0872cfea9a1241b2a56f7bede7fa291a..934bee079ed785e4e72f33f71f445aae4ca6c0a6 100644
171+
index 27402b3061afba6112a77f31d1b4c7c0d2526ba0..6719cd91d48676ed551b748b1ff3ec2f21d08e86 100644
172172
--- a/node.gyp
173173
+++ b/node.gyp
174-
@@ -184,9 +184,9 @@
174+
@@ -185,9 +185,9 @@
175175
'src/timers.cc',
176176
'src/timer_wrap.cc',
177177
'src/tracing/agent.cc',
@@ -182,7 +182,7 @@ index 0620850e0872cfea9a1241b2a56f7bede7fa291a..934bee079ed785e4e72f33f71f445aae
182182
'src/tracing/traced_value.cc',
183183
'src/tty_wrap.cc',
184184
'src/udp_wrap.cc',
185-
@@ -318,9 +318,9 @@
185+
@@ -320,9 +320,9 @@
186186
'src/tcp_wrap.h',
187187
'src/timers.h',
188188
'src/tracing/agent.h',
@@ -194,10 +194,10 @@ index 0620850e0872cfea9a1241b2a56f7bede7fa291a..934bee079ed785e4e72f33f71f445aae
194194
'src/tracing/traced_value.h',
195195
'src/timer_wrap.h',
196196
diff --git a/src/async_wrap.cc b/src/async_wrap.cc
197-
index 4ebb63b2f591dde25ead2ddd869e1740adc243db..f9123d5a629a43783b9a3ffe14b57f6d6cc9ac5d 100644
197+
index b7d0041d0737f7e0315216748e3a5908428c7d1c..b48efd7e1a611dddb5724d65d623c8a20168d252 100644
198198
--- a/src/async_wrap.cc
199199
+++ b/src/async_wrap.cc
200-
@@ -113,8 +113,7 @@ void AsyncWrap::EmitPromiseResolve(Environment* env, double async_id) {
200+
@@ -110,8 +110,7 @@ void AsyncWrap::EmitPromiseResolve(Environment* env, double async_id) {
201201
}
202202

203203
void AsyncWrap::EmitTraceAsyncStart() const {
@@ -254,7 +254,7 @@ index 40c8aea35c931c46fc62b717c978eab0659645fd..348cdfb0b42aa18f352c220cea0b896c
254254
if (!json_writer_)
255255
return;
256256
diff --git a/src/node.cc b/src/node.cc
257-
index 0bc086ccd1ff449c0f3fb08a972a0c45d3178f1c..ca74e83ef6f7b0e8b8496457af3813f07f52eb37 100644
257+
index 6f899ec0621ada45fb04c921359bc9b9ea79132b..4178e13dc8b5769c06fb720b2fcc655eb46aef5a 100644
258258
--- a/src/node.cc
259259
+++ b/src/node.cc
260260
@@ -78,6 +78,11 @@
@@ -269,7 +269,7 @@ index 0bc086ccd1ff449c0f3fb08a972a0c45d3178f1c..ca74e83ef6f7b0e8b8496457af3813f0
269269
#if defined(__APPLE__) || defined(__linux__) || defined(_WIN32)
270270
#define NODE_USE_V8_WASM_TRAP_HANDLER 1
271271
#else
272-
@@ -1261,6 +1266,14 @@ InitializeOncePerProcessInternal(const std::vector<std::string>& args,
272+
@@ -1264,6 +1269,14 @@ InitializeOncePerProcessInternal(const std::vector<std::string>& args,
273273
absl::SetMutexDeadlockDetectionMode(absl::OnDeadlockCycle::kIgnore);
274274
}
275275

@@ -285,10 +285,10 @@ index 0bc086ccd1ff449c0f3fb08a972a0c45d3178f1c..ca74e83ef6f7b0e8b8496457af3813f0
285285
bool use_wasm_trap_handler =
286286
!per_process::cli_options->disable_wasm_trap_handler;
287287
diff --git a/src/node_contextify.cc b/src/node_contextify.cc
288-
index d3568da72a0f99419b4029b93d9eb1e9328d6bd5..0f5da3e48a2049a3e61fe81da94426a3b5928c7d 100644
288+
index 211bc074161b5fd4ac6f2d9a23b201d79ae362ef..0a692075dfeab6fb880b2ca6d52c2d45ce527276 100644
289289
--- a/src/node_contextify.cc
290290
+++ b/src/node_contextify.cc
291-
@@ -1001,8 +1001,7 @@ void ContextifyScript::New(const FunctionCallbackInfo<Value>& args) {
291+
@@ -1028,8 +1028,7 @@ void ContextifyScript::New(const FunctionCallbackInfo<Value>& args) {
292292

293293
ContextifyScript* contextify_script = New(env, args.This());
294294

@@ -331,7 +331,7 @@ index c9173d404c79a69743fc75ddb6bba0ac9579c1ef..8ffac047a69b3900f37d712334c504a1
331331
#define FS_DIR_ASYNC_TRACE_BEGIN0(fs_type, id) \
332332
TRACE_EVENT_NESTABLE_ASYNC_BEGIN0(TRACING_CATEGORY_NODE2(fs_dir, async), \
333333
diff --git a/src/node_file.cc b/src/node_file.cc
334-
index bf202f5e2bf5eaf2dd9192dfd701e621126c492c..4c0a128628e0184af53451d37149b33342f6e647 100644
334+
index d828e7e78f9b41e053c306b01a71ad3ad847aaf6..0bd206a6b4f423a67b6fedc0790faa6eb35d5b97 100644
335335
--- a/src/node_file.cc
336336
+++ b/src/node_file.cc
337337
@@ -147,16 +147,23 @@ static const char* get_fs_func_name_by_type(uv_fs_type req_type) {

‎patches/node/build_ensure_native_module_compilation_fails_if_not_using_a_new.patch‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ Subject: build: ensure native module compilation fails if not using a new
77
This should not be upstreamed, it is a quality-of-life patch for downstream module builders.
88

99
diff --git a/common.gypi b/common.gypi
10-
index d398e33d5acc9acd096e2c263a6f8ad9d947d1b0..f760bb6e6a498c3f9786b46b60fbbf38521ab60a 100644
10+
index ad23752a8b999715503b85466e9c53acbbe4bf94..6432c78010c7575f56641a86eb971a4fcd9e578f 100644
1111
--- a/common.gypi
1212
+++ b/common.gypi
1313
@@ -89,6 +89,8 @@
@@ -42,10 +42,10 @@ index d398e33d5acc9acd096e2c263a6f8ad9d947d1b0..f760bb6e6a498c3f9786b46b60fbbf38
4242
# list in v8/BUILD.gn.
4343
['v8_enable_v8_checks == 1', {
4444
diff --git a/configure.py b/configure.py
45-
index fc48438060e0dd84edc60d1aebf3d0946be98ea9..4e30f58c3f33ed400301ed08a365a738b49f530f 100755
45+
index 8f101999c20ef9d59d96d507b403f13cf9f23ae8..473a7d0165fadae5cd4fd3085f6f3c872ea63f3f 100755
4646
--- a/configure.py
4747
+++ b/configure.py
48-
@@ -1810,6 +1810,7 @@ def configure_library(lib, output, pkgname=None):
48+
@@ -1869,6 +1869,7 @@ def configure_library(lib, output, pkgname=None):
4949
def configure_v8(o, configs):
5050
set_configuration_variable(configs, 'v8_enable_v8_checks', release=0, debug=1)
5151

‎patches/node/build_modify_js2c_py_to_allow_injection_of_original-fs_and_custom_embedder_js.patch‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,10 +10,10 @@ JS errors and ensures embedder JS is loaded via LoadEmbedderJavaScriptSource.
1010
That method is generated by our modifications to js2c.cc in the BUILD.gn patch
1111

1212
diff --git a/lib/internal/fs/watchers.js b/lib/internal/fs/watchers.js
13-
index a493c9579669072d97c7caa9049e846bda36f8b9..334ffaa6f2d955125ca8b427ace1442c94011e18 100644
13+
index c540307d79a52d75007e9f68ec4ca7f087ed8b76..27ac7cb42d75ade0c645b3ed59d0e6f984feb847 100644
1414
--- a/lib/internal/fs/watchers.js
1515
+++ b/lib/internal/fs/watchers.js
16-
@@ -361,12 +361,13 @@ function emitCloseNT(self) {
16+
@@ -366,12 +366,13 @@ function emitCloseNT(self) {
1717
}
1818

1919
// Legacy alias on the C++ wrapper object. This is not public API, so we may
@@ -34,10 +34,10 @@ index a493c9579669072d97c7caa9049e846bda36f8b9..334ffaa6f2d955125ca8b427ace1442c
3434
let kResistStopPropagation;
3535

3636
diff --git a/src/node_builtins.cc b/src/node_builtins.cc
37-
index a077ad673fdf7eab61878940e5fef43921c2e453..7922f2f936f64cbb7bd08f0d367f66f0b9eb083b 100644
37+
index edcf2d8424f9b60d68ddd95b16da488feec2c41b..4d16947fa90066393672f511234702e5877c8ea7 100644
3838
--- a/src/node_builtins.cc
3939
+++ b/src/node_builtins.cc
40-
@@ -46,6 +46,7 @@ using v8::Value;
40+
@@ -47,6 +47,7 @@ using v8::Value;
4141
BuiltinLoader::BuiltinLoader()
4242
: config_(GetConfig()), code_cache_(std::make_shared<BuiltinCodeCache>()) {
4343
LoadJavaScriptSource();

‎patches/node/build_restore_clang_as_default_compiler_on_macos.patch‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ node-gyp will use the result of `process.config` that reflects the environment
1111
in which the binary got built.
1212

1313
diff --git a/common.gypi b/common.gypi
14-
index f760bb6e6a498c3f9786b46b60fbbf38521ab60a..d9ba0816ae424e5eb77fa742f8fd3d2d1c9845fc 100644
14+
index 6432c78010c7575f56641a86eb971a4fcd9e578f..60c18e79d104e355276c108a7e577a846726ce3d 100644
1515
--- a/common.gypi
1616
+++ b/common.gypi
1717
@@ -128,6 +128,7 @@

0 commit comments

Comments
 (0)