Repository navigation
Warning: The dynamicInstantiate loader hook has been removed. #105
Description
dynamicInstantiate loader hook is gone since Node v14.5.0.
It causes warning:
Warning: The dynamicInstantiate loader hook has been removed.
For some code, including the test suite of this repository, it causes error:
RangeError [ERR_UNKNOWN_MODULE_FORMAT]: Unknown module format: dynamic
at Loader.getModuleJob (internal/modules/esm/loader.js:236:13)
at async ModuleWrap.<anonymous> (internal/modules/esm/module_job.js:53:21)
at async Promise.all (index 3)
at async link (internal/modules/esm/module_job.js:58:9) {
code: 'ERR_UNKNOWN_MODULE_FORMAT'
}
nodejs/node#33501 explains why they removed dynamicInstantiate.
Activity
mk: downgrade to Node v14.4; upgrade packages
mk: downgrade to Node v14.4; upgrade packages
EntraptaJ commentedon Jul 8, 2020
Well, fuck. Any ideas how we can work around this while still supporting drop in compatibility with older libraries?
EntraptaJ commentedon Jul 8, 2020
As happy as I am that I have to remove the hack, I don't know any other "easy" way of supporting external modules with fucky exports.
EntraptaJ commentedon Jul 8, 2020
I just got deep into a server administration project for work, I might not be able to get to solving this quickly, I've been burned out from programming for a little bit, although I'd be happy to review, test, and merge a potential solution if anyone wants.
EntraptaJ commentedon Sep 15, 2020
So, after taking a 3 month break from programming. I'm back, I almost have a fix for this. I can't get React SSR tests working, otherwise everything else is functional
EntraptaJ commentedon Sep 15, 2020
Fix has been released. I haven't tested it in my projects yet. But all tests are passing.
yoursunny commentedon Sep 16, 2020
It's working for me on Node 14.11.
yoursunny/NDNts@65e493a
EntraptaJ commentedon Sep 16, 2020
Awesome, sorry for the delay on fixing this one. Took a bit of a break from programming.
EntraptaJ commentedon Sep 16, 2020
I also have it working in my new SSH-Proxy which is using the latest
node:alpine3.12image in the dev container. I haven't fully tested if@k-foss/ts-esnode=>1.7.0works with node 14.4 and below, but the tests appear to be passing in Node.JS 13.8