Skip to content

Commit 93ccff1

Browse files
committed
pass to a variable to save double computation
1 parent 714408f commit 93ccff1

1 file changed

Lines changed: 2 additions & 3 deletions

File tree

‎apps/rush-lib/src/logic/pnpm/PnpmShrinkwrapFile.ts‎

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -273,9 +273,8 @@ export class PnpmShrinkwrapFile extends BaseShrinkwrapFile {
273273
}
274274

275275
private _getValidDependencyVersion(dependencyVersion: string): string {
276-
return semver.valid(dependencyVersion.split('/').pop()!) ?
277-
dependencyVersion.split('/').pop()! :
278-
dependencyVersion.split('_')[0]!;
276+
const validDependencyVersion = dependencyVersion.split('/').pop()!;
277+
return semver.valid(validDependencyVersion) ? validDependencyVersion : dependencyVersion.split('_')[0]!;
279278
}
280279

281280
private _getTempProjectKey(tempProjectName: string): string {

0 commit comments

Comments
 (0)