Skip to content

Commit 6ef46d1

Browse files
committed
Fixed some mobservable-react related build issues
1 parent 4ff316c commit 6ef46d1

4 files changed

Lines changed: 16 additions & 6 deletions

File tree

‎CHANGELOG.md‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ This means that it is allowed in an to change the state in such a way that the s
1414
* minified file moved
1515
* smaller distro: 74 -> 60 KB unminified, 54 -> 30 KB minified
1616
* Faster
17+
* extras.SimpleEventEmitter -> SimpleEventEmitter
1718

1819
# 1.2.4
1920

‎scripts/single-file-build.sh‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ cat src/mobservable.ts | grep -v '^import' | sed -e 's/from.*$//g' >> .build/mob
2323
ls src/{core,types,api,utils}/*.ts | xargs awk 'BEGINFILE {print "/* file:", FILENAME, "*/"} {print $0}' | grep -v '^import ' | sed -e 's/^export //g' >> .build/mobservable.ts
2424

2525
# compile, generate declaration, no comments
26-
tsc -m umd -t es5 -d --removeComments --sourcemap --outDir lib .build/mobservable.ts
26+
tsc -m commonjs -t es5 -d --removeComments --sourcemap --outDir lib .build/mobservable.ts
2727

2828
# idea: strip invariants from compiled result. However, difference is not really significant in speed and size, disabled for now.
2929
# cat lib/mobservable.js | grep -v -P '^\s+invariant' > .build/mobservable-prod.js

‎src/mobservable.ts‎

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@ registerGlobals();
2626

2727
// TODO: all exports in sync with docs?
2828
export { Lambda } from "./utils/utils";
29+
export { SimpleEventEmitter } from "./utils/simpleeventemitter";
2930
export { ITransitionEvent, IObserverTree, IDependencyTree } from "./api/extras";
3031
export { IObservable, IDepTreeNode } from "./core/observable";
3132
export { IDerivation } from "./core/derivation";
@@ -46,8 +47,8 @@ export { ITransformer, createTransformer } from "./api/crea
4647

4748
export { untracked } from "./core/globalstate";
4849
export { transaction } from "./core/transaction";
49-
export { Reaction } from "./core/reaction";
50-
50+
export { Reaction } from "./core/reaction";
51+
export { IAtom, Atom } from "./core/atom";
5152

5253
import { isComputingDerivation, resetGlobalState } from "./core/globalstate";
5354
import { quickDiff } from "./utils/utils";
@@ -58,12 +59,10 @@ export const _ = {
5859
}
5960

6061
import { ITransitionEvent, IObserverTree, IDependencyTree } from "./api/extras";
61-
import { SimpleEventEmitter } from "./utils/simpleeventemitter";
6262
import { getDependencyTree, getObserverTree, trackTransitions, allowStateChanges } from "./api/extras";
6363
import { Lambda } from "./utils/utils";
6464

6565
export const extras = {
66-
SimpleEventEmitter: <any> SimpleEventEmitter,
6766
getDependencyTree,
6867
getObserverTree,
6968
trackTransitions,

‎test/api.js‎

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,10 @@ var test = require('tape');
33

44
test('correct api should be exposed', function(t) {
55
t.deepEquals(Object.keys(mobservable).sort(), [
6+
'Atom',
67
'ObservableMap',
78
'Reaction',
9+
'SimpleEventEmitter',
810
'_',
911
'asFlat',
1012
'asReference',
@@ -29,20 +31,28 @@ test('correct api should be exposed', function(t) {
2931
'untracked',
3032
'when'
3133
]);
34+
t.equals(Object.keys(mobservable).filter(function(key) {
35+
return mobservable[key] == undefined;
36+
}).length, 0);
3237

3338
t.deepEquals(Object.keys(mobservable._).sort(), [
3439
'quickDiff',
3540
'resetGlobalState'
3641
]);
42+
t.equals(Object.keys(mobservable._).filter(function(key) {
43+
return mobservable._[key] == undefined;
44+
}).length, 0);
3745

3846
t.deepEquals(Object.keys(mobservable.extras).sort(), [
39-
'SimpleEventEmitter',
4047
'allowStateChanges',
4148
'getDependencyTree',
4249
'getObserverTree',
4350
'isComputingDerivation',
4451
'trackTransitions'
4552
]);
53+
t.equals(Object.keys(mobservable.extras).filter(function(key) {
54+
return mobservable.extras[key] == undefined;
55+
}).length, 0);
4656

4757
t.end();
4858
});

0 commit comments

Comments
 (0)