Skip to content

Commit 4433d52

Browse files
authored
Merge pull request glennreyes#15 from rjoydip/master
refactor: sourcemap control, apollo server port dynamic, port as argument
2 parents 3b3f8e3 + d6a903e commit 4433d52

3 files changed

Lines changed: 8 additions & 9 deletions

File tree

‎packages/graphpack/bin/graphpack.js‎

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -37,12 +37,11 @@ const startGraphPack = async () => {
3737
const compiler = webpack(config);
3838

3939
require('yargs')
40-
.command(['$0', 'dev'], 'Start graphpack dev server', {}, () =>
41-
startDevServer({ compiler, config }),
42-
)
43-
.command('build', 'Create production build', {}, () =>
44-
createProductionBuild({ compiler }),
45-
).argv;
40+
.command(['$0', 'dev'], 'Start graphpack dev server', {}, yargs => {
41+
process.env.PORT = yargs.port || yargs.p || yargs.PORT || yargs.P;
42+
startDevServer({ compiler, config });
43+
})
44+
.command('build', 'Create production build', {}, () => createProductionBuild({ compiler })).argv;
4645
};
4746

4847
startGraphPack();

‎packages/graphpack/config/webpack.config.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ if (hasBabelRc) {
1212
}
1313

1414
module.exports = {
15-
devtool: 'sourcemap',
15+
devtool: IS_DEV ? 'sourcemap': 'none',
1616
entry: {
1717
// We take care of setting up entry file under lib/index.js
1818
index: ['graphpack'],
@@ -58,7 +58,7 @@ module.exports = {
5858
filename: '[name].js',
5959
libraryTarget: 'commonjs2',
6060
path: path.join(process.cwd(), './build'),
61-
sourceMapFilename: '[name].map',
61+
sourceMapFilename: '[name].map'
6262
},
6363
performance: {
6464
hints: false,

‎packages/graphpack/lib/server.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ const server = new ApolloServer({
2929
});
3030

3131
server
32-
.listen({ port: 4000 })
32+
.listen({ port: ((config.PORT || config.port) || (process.env.PORT || 4000)) })
3333
.then(({ url }) => console.log(`🚀 Server ready at ${url}`));
3434

3535
export default server;

0 commit comments

Comments
 (0)