Skip to content

Commit 1c9de99

Browse files
g1ytdcmeehan
g1y
authored and
tdcmeehan
committed
Fix CI for next snapshot iteration PRs
The new release process for presto creates pull requests that have an incremented snapshot which hasn't been built by anything yet. There are tests that are building test coverage but skipping presto server. This creates a problem where they are requesting dependencies that aren't built yet. We don't need test-coverage in these tests, so it's best if we just skip building those modules.
1 parent 50b0e44 commit 1c9de99

4 files changed

Lines changed: 6 additions & 5 deletions

File tree

‎.github/workflows/product-tests-basic-environment.yml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,6 @@ jobs:
3434
- name: Maven install
3535
run: |
3636
export MAVEN_OPTS="${MAVEN_INSTALL_OPTS}"
37-
./mvnw install ${MAVEN_FAST_INSTALL} -am -pl '!presto-docs,!presto-server-rpm,!presto-spark-package,!presto-spark-launcher,!presto-spark-testing'
37+
./mvnw install ${MAVEN_FAST_INSTALL} -am -pl '!presto-docs,!presto-server-rpm,!presto-spark-package,!presto-spark-launcher,!presto-spark-testing,!presto-test-coverage'
3838
- name: Run Product Tests Basic Environment
3939
run: presto-product-tests/bin/run_on_docker.sh multinode -x quarantine,big_query,storage_formats,profile_specific_tests,tpcds,cassandra,mysql_connector,postgresql_connector,mysql,kafka,avro

‎.github/workflows/product-tests-specific-environment.yml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ jobs:
3434
- name: Mave install
3535
run: |
3636
export MAVEN_OPTS="${MAVEN_INSTALL_OPTS}"
37-
./mvnw install ${MAVEN_FAST_INSTALL} -am -pl '!presto-docs,!presto-server-rpm,!presto-spark-package,!presto-spark-launcher,!presto-spark-testing'
37+
./mvnw install ${MAVEN_FAST_INSTALL} -am -pl '!presto-docs,!presto-server-rpm,!presto-spark-package,!presto-spark-launcher,!presto-spark-testing,!presto-test-coverage'
3838
- name: Product Tests Specific 1.1
3939
run: presto-product-tests/bin/run_on_docker.sh singlenode -g hdfs_no_impersonation,avro
4040
- name: Product Tests Specific 1.2

‎.github/workflows/test-native.yml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@ jobs:
8989
- name: Maven Install
9090
run: |
9191
export MAVEN_OPTS="${MAVEN_INSTALL_OPTS}"
92-
./mvnw install ${MAVEN_FAST_INSTALL} -pl '!presto-docs,!presto-server,!presto-server-rpm'
92+
./mvnw install ${MAVEN_FAST_INSTALL} -pl '!presto-docs,!presto-server,!presto-server-rpm,!presto-test-coverage'
9393
9494
- name: Run e2e tests
9595
run: |

‎.github/workflows/test-other-modules.yml‎

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ jobs:
3535
- name: Maven Install
3636
run: |
3737
export MAVEN_OPTS="${MAVEN_INSTALL_OPTS}"
38-
./mvnw install ${MAVEN_FAST_INSTALL} -pl '!:presto-docs,!:presto-server,!:presto-server-rpm'
38+
./mvnw install ${MAVEN_FAST_INSTALL} -pl '!:presto-docs,!:presto-server,!:presto-server-rpm,!presto-test-coverage'
3939
- name: Maven Tests
4040
run: |
4141
./mvnw test ${MAVEN_TEST} -pl '
@@ -58,4 +58,5 @@ jobs:
5858
!presto-elasticsearch,
5959
!presto-orc,
6060
!presto-thrift-connector,
61-
!presto-native-execution'
61+
!presto-native-execution,
62+
!presto-test-coverage'

0 commit comments

Comments
 (0)