Skip to content
This repository was archived by the owner on Jan 25, 2023. It is now read-only.
This repository was archived by the owner on Jan 25, 2023. It is now read-only.

numba-dppy extension #76

Description

@PokhodenkoSA

Reorganize code base and initial version of numba-dppy extension

  • Move the numba.dppl package to its own repository (i.e. numba-dppy)
  • All core Numba changes to be outlined as patches needed to build Numba with numba-dppy
  • All patches need to be analyzed if they can be refactored or converted into plugins

PRs for cleaning unintended changes (make branch pydppl as close as possible to release0.51 branch):

PRs with patches (after refactoring it could be proposed to upstream, it is for starting discussion about this changes):

All upstream patches has label https://github.com/numba/numba/labels/dpPy.

PRs which should me moved to numba-dppy package:

Process current PRs to numba:

Patched version: #124

How to see our changes: git diff release0.51..pydppl

Recommended way of development now:

  1. Create conda environment
  2. Clone https://github.com/IntelPython/dpctl from branch master. Call: python setup.py develop.
  3. Clone https://github.com/IntelPython/numba from branch patched. Call: python setup.py develop.
  4. Clone https://github.com/IntelPython/numba-dppy from branch main. Call: python setup.py develop.
  5. Install required conda packages if python setup.py develop shows that some packages are not installed.

Branches status

  1. patched - contains release0.51 branch, minimal set of patches.
  2. pydppl - contains all history, code similar to patched, numba-dppy subtree.
  3. clean - contains all history, all patches removed, numba-dppy subtree removed - code the same as release0.51
  4. patched-history - contains clean, minimal set of patches.

You should target your PRs to patched branch, because it is simpler than pydppl but contains the same code.

Activity

  1. PokhodenkoSA commented on Nov 2, 2020

    @PokhodenkoSA
    Author

    Related #51 - closed by #86.

  2. PokhodenkoSA commented on Nov 12, 2020

    @PokhodenkoSA
    Author

    From @diptorupd:

    • What if dpCtl is installed and numba-dppy is not?
    • How numba-dppy will understand that IntelPython/numba is installed?
  3. PokhodenkoSA commented on Dec 2, 2020

    @PokhodenkoSA
    Author

    I need a way to build new package with all modifications (i.e. removing numba.dppl folder) but make it different from packages we build before. Build number I think is not visible enough. Using next version 0.51.3 loses connection to base Numba version. Using 0.51.2rc1 is also not related to upstream version. Possibly, introducing new end number 0.51.2.1 is ok. Also it is pretty close in goal to buildnumber but more visible.

  4. PokhodenkoSA commented on Dec 16, 2020

    @PokhodenkoSA
    Author

    a way to build new package with all modifications (i.e. removing numba.dppl folder) but make it different from packages we build before

    We decided to use build number which is significantly different from previous one. I.e. use build number 20 when the last one was 12.

  5. reazulhoque commented on Feb 11, 2021

    @reazulhoque
  6. PokhodenkoSA commented on Mar 31, 2021

    @PokhodenkoSA
    Author

    @reazulhoque why did you decide to make a copy of part of description and do not modify description itself?

  7. reazulhoque commented on Mar 31, 2021

    @reazulhoque

    I intended to update the ticket. Modifying the descripton would change the original and stops from keeping versions and updates separate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions