Repository navigation
Using __array_interface__ instead of adding __sycl_usm_array_interface__ #191
Description
Activity
- changed the title
[-]Usgin __array_interface__ instead of adding __sycl_usm_array_interface__[/-][+]Using __array_interface__ instead of adding __sycl_usm_array_interface__[/+]on Dec 3, 2020 These two properties serve different purposes, and can not be combined. One does not have to check for both. Please clarify what performance penalty you have in mind.
different purposes
Does it mean that we will always know exactly which property we need?
Please clarify what performance penalty you have in mind.
Double checking both properties. One for SYCL queue (
__sycl_usm_array_interface__) and another for fallback to usual__array_interface__if the first property is not available.NumPy checks for
__array_interface__trying to recognize a Python object as a "duck-array", also known as "array-like" . This property has been largely superseded by Python buffer protocol.Python objects backed by USM memory export
__sycl_usm_array_interface__to be recognized as carriers of USM memory.Closing since @oleksandr-pavlyk's comments explains the rationale of why the two attributes are needed.
Using 2 properties
__array_interface__and__sycl_usm_array_interface__in dparray requires 2 checks in downstream libraries.Performance penalty.
Related to #184.
/CC @oleksandr-pavlyk @shssf