Skip to content

Commit c034e46

Browse files
committed
ENH: Fix compiler flags
1 parent 1287aab commit c034e46

2 files changed

Lines changed: 4 additions & 4 deletions

File tree

‎scripts/build_python_instance_base.py‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -88,8 +88,8 @@ def __init__(
8888
self.cmake_compiler_configurations.update(
8989
{
9090
"CMAKE_BUILD_TYPE:STRING": f"{self._build_type}",
91-
"CMAKE_CXX_FLAGS:STRING": "\"-O3 -DNDEBUG\"",
92-
"CMAKE_C_FLAGS:STRING": "\"-O3 -DNDEBUG\"",
91+
"CMAKE_CXX_FLAGS:STRING": '"-O3 -DNDEBUG"',
92+
"CMAKE_C_FLAGS:STRING": '"-O3 -DNDEBUG"',
9393
}
9494
)
9595
# Set cmake flags for the compiler if CC or CXX are specified

‎scripts/linux_build_python_instance.py‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -67,8 +67,8 @@ def prepare_build_env(self) -> None:
6767
)
6868

6969
# Keep values consistent with prior quoting behavior
70-
self.cmake_compiler_configurations.set("CMAKE_CXX_FLAGS:STRING", "\"-O3 -DNDEBUG\"")
71-
self.cmake_compiler_configurations.set("CMAKE_C_FLAGS:STRING", "\"-O3 -DNDEBUG\"")
70+
self.cmake_compiler_configurations.set("CMAKE_CXX_FLAGS:STRING", "-O3 -DNDEBUG")
71+
self.cmake_compiler_configurations.set("CMAKE_C_FLAGS:STRING", "-O3 -DNDEBUG")
7272

7373
def post_build_fixup(self) -> None:
7474
manylinux_ver: str | None = self.package_env_config.get(

0 commit comments

Comments
 (0)