Skip to content

Commit 5e9784b

Browse files
committed
Build Python 3.6 on Windows
CMake and Ninja Python packages for 3.6 do not currently exist. Re-use the 2.7 venv Ninja executable and require an installed CMake.
1 parent 9a486a4 commit 5e9784b

2 files changed

Lines changed: 4 additions & 6 deletions

File tree

‎README.md‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -66,8 +66,8 @@ itk-4.11.0.dev20170213-cp36-cp36m-macosx_10_6_x86_64.whl
6666

6767
First, install [Microsoft Visual C++ Compiler for Python
6868
2.7](http://aka.ms/vcpython27), [Visual Studio
69-
2015](https://www.visualstudio.com/downloads/), and
70-
[Git](https://git-scm.com/download/win).
69+
2015](https://www.visualstudio.com/downloads/),
70+
[Git](https://git-scm.com/download/win), and [CMake](https://cmake.org/download/), which should be added to the system `PATH` environmental variable.
7171

7272
Open a PowerShell terminal as Administrator, and install Python:
7373

‎scripts/windows-build-wheels.ps1‎

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -35,8 +35,6 @@ param (
3535
Start-Process $venv -ArgumentList "$venvDir" -NoNewWindow -Wait
3636
}
3737

38-
Pip-Install "$venvDir" "cmake"
39-
Pip-Install "$venvDir" "ninja"
4038
Pip-Install "$venvDir" "scikit-build"
4139
}
4240

@@ -60,7 +58,6 @@ param (
6058
Write-Host "PYTHON_LIBRARY:${PYTHON_LIBRARY}"
6159

6260
$pip = Join-Path $venvDir "Scripts\\pip.exe"
63-
$NINJA_EXECUTABLE = Join-Path $venvDir "Scripts\\ninja.exe"
6461

6562
# Update PATH
6663
$old_path = $env:PATH
@@ -78,6 +75,7 @@ param (
7875

7976
Prepare-Build-Env "27-x64"
8077
Prepare-Build-Env "35-x64"
78+
Prepare-Build-Env "36-x64"
8179

8280
Pushd $standaloneDir
8381
$CMAKE_EXECUTABLE = Join-Path $rootDir "venv-27-x64\Scripts\cmake.exe"
@@ -94,4 +92,4 @@ Popd
9492
# Compile wheels re-using standalone project and archive cache
9593
Build-Wheel "27-x64"
9694
Build-Wheel "35-x64"
97-
95+
Build-Wheel "36-x64"

0 commit comments

Comments
 (0)