Repository navigation
Unified logging of resource identifiers so that we can reliably get entire history of a resource in stack driver. - #616
Merged
Conversation
Collaborator
|
Build Failed 😱 Build Id: 4a8eab40-a840-4ab3-a542-1269c28a4af3 To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
jkowalski
force-pushed
the
gs-logging
branch
from
February 21, 2019 22:40
c447e54 to
4d4c46c
Compare
Collaborator
|
Build Succeeded 👏 Build Id: 8e14a0a7-b085-48c8-93f9-2d87f41d453e The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
markmandel
reviewed
Feb 22, 2019
markmandel
left a comment
markmandel
left a comment
Member
There was a problem hiding this comment.
Overall - awesome. Had a few questions, and a couple of small cleanup items.
| err := json.Unmarshal(obj.Raw, gsa) | ||
| if err != nil { | ||
| c.logger.WithError(err).Error("error unmarchaslling json") | ||
| c.baseLogger.WithError(err).Error("error unmarchalling json") |
Member
There was a problem hiding this comment.
Suggested change
| c.baseLogger.WithError(err).Error("error unmarchalling json") | |
| c.baseLogger.WithError(err).Error("error unmarshalling json") |
| "strings" | ||
|
|
||
| "agones.dev/agones/pkg/util/logfields" | ||
|
|
| } | ||
|
|
||
| func loggerForGameServerSetKey(base *logrus.Entry, key string) *logrus.Entry { | ||
| return base.WithField(gameServerSetKeyFieldName, key) |
Member
There was a problem hiding this comment.
Should this not use logfields.GameServerSetKey ?
| "time" | ||
|
|
||
| "agones.dev/agones/pkg/util/logfields" | ||
|
|
jkowalski
force-pushed
the
gs-logging
branch
from
February 22, 2019 22:28
4d4c46c to
0cff425
Compare
…n entire history of a resource in stack driver. Well-known identifiers of resources types are defined in logfields package.
jkowalski
force-pushed
the
gs-logging
branch
from
February 22, 2019 22:29
0cff425 to
31fa9d2
Compare
Collaborator
|
Build Succeeded 👏 Build Id: 21b80715-7cab-4184-8cb7-272f68fcc057 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
Collaborator
|
Build Succeeded 👏 Build Id: 544d6b8c-3ce8-4c0f-a7cb-5b71caa9b9dd The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
Collaborator
|
Build Succeeded 👏 Build Id: a9b24bc3-f9f9-41c4-9115-1adc2fcdf298 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Well-known identifiers of resources types are defined in new
logfieldspackage.