Repository navigation
Delete crds, and fleets, gameservers etc on deletion of Helm chart - #437
Merged
Merged
Conversation
Collaborator
|
Build Failed 😱 Build Id: c6bdb886-aad1-4d0e-af14-04054464b0bb Build Logs |
Collaborator
|
Build Succeeded 👏 Build Id: ae5b205b-23ad-4c73-b90b-4b79dd0064db The following development artifacts have been built, and will exist for the next 30 days:
To install this version:
|
cyriltovena
approved these changes
Dec 3, 2018
| - name: script | ||
| configMap: | ||
| name: delete-crds | ||
| {{- end }} No newline at end of file |
Collaborator
There was a problem hiding this comment.
nitpick: I think there is some missing carrier return in some files.
Collaborator
|
You need to rebase and squash btw. |
markmandel
reviewed
Dec 3, 2018
markmandel
left a comment
markmandel
left a comment
Member
There was a problem hiding this comment.
Minor addition as well, otherwise lgtm
| @@ -0,0 +1,30 @@ | |||
| #!/bin/sh | |||
Member
There was a problem hiding this comment.
This file needs a licence header 👍
EricFortin
force-pushed
the
bugfix/helm-delete
branch
from
December 4, 2018 11:32
fbdb3fa to
aa692be
Compare
Collaborator
|
Build Succeeded 👏 Build Id: 8556d697-9e1d-4972-a45b-d63864f2f2f2 The following development artifacts have been built, and will exist for the next 30 days:
To install this version:
|
markmandel
added
kind/cleanup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements helm hooks to delete all Agones resources and CRDs when uninstalling our chart.
Deletion of resources is done in a pre-delete hook while crds are deleted in a post-delete hook. Had to add a new service account and a few other resources to accomplish it.
Fixes #426