Repository navigation
Add Amazon EKS Agones Setup Instructions - #372
Merged
Merged
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
Collaborator
|
Build Succeeded 👏 Build Id: 86bbbdb5-c163-41d9-ba9d-10ac2f013a4f The following development artifacts have been built, and will exist for the next 30 days:
(experimental) To install this version:
|
Contributor
Author
|
I signed it! |
markmandel
reviewed
Oct 4, 2018
| - name: default | ||
| portPolicy: "dynamic" | ||
| containerPort: 7654 # ADD THIS | ||
| hostPort: 7654 # ADD THIS |
Member
There was a problem hiding this comment.
Why do you need to set the hostPort, when the port policy is dynamic?
Also, you shouldn't have to set it at the pod level either - Agones should take care of that for you -- was there issue without it?
Contributor
Author
There was a problem hiding this comment.
Good catch, I set it since in my case it's portPolicy: "static"
No, I haven't tested it only at the pod level, let me try that now and verify it works.
Contributor
Author
|
I signed it! |
|
CLAs look good, thanks! |
Collaborator
|
Build Failed 😱 Build Id: 83d20a16-e7c5-4f8f-bbf4-81f68e6f1144 Build Logs |
Collaborator
|
Build Succeeded 👏 Build Id: 61a2c8ea-7b1a-4ccf-95b5-ee8a67a4a21c The following development artifacts have been built, and will exist for the next 30 days:
(experimental) To install this version:
|
markmandel
reviewed
Oct 4, 2018
| 1. [Create EKS Instance](#create-eks-instance) | ||
| 1. [Ensure VPC CNI 1.2 is Running](#ensure-vpc-cni-12-is-running) | ||
| 1. [Follow Normal Instructions to Install](#follow-normal-instructions-to-install) | ||
| 1. [Add HostPort to fleet or gameserver instructions](#add-hostport-to-fleet-or-gameserver-instructions) |
Member
There was a problem hiding this comment.
I believe this should go too? 😄
Also, please rebase down to a single commit - and once this header is gone, happy to approve and merge.
Collaborator
|
Build Succeeded 👏 Build Id: 5697715c-5920-4fcb-a667-6bc4d0603feb The following development artifacts have been built, and will exist for the next 30 days:
(experimental) To install this version:
|
Collaborator
|
Build Failed 😱 Build Id: e2e7168d-9091-446d-adf7-32b272e680b0 Build Logs |
Member
|
Looks like test flakiness. rerunning. |
Collaborator
|
Build Succeeded 👏 Build Id: 0cac0be5-9665-450a-ba1f-7c6d684d99a8 The following development artifacts have been built, and will exist for the next 30 days:
(experimental) To install this version:
|
markmandel
added
kind/feature
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added basic instructions to get Agones up and running in the EKS networking environment.