Repository navigation
Flaky test fix: TestWorkQueueHealthCheck - #260
Merged
enocom merged 1 commit intoJun 13, 2018
Merged
Conversation
I believe this shoud fix this flakey test
Collaborator
|
Build Succeeded 👏 Build Id: 54ba3e0e-ea13-4657-a360-9a82a2705d88 The following development artifacts have been built, and will exist for the next 30 days:
|
Member
Author
|
@enocom is this hacky, or genius, or both? 😄 (review if you have time) |
enocom
self-requested a review
June 13, 2018 01:44
enocom
approved these changes
Jun 13, 2018
enocom
left a comment
enocom
left a comment
Contributor
There was a problem hiding this comment.
Writing robust tests against concurrent code is hard. This looks like a more robust approach. 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I believe this should fix this flaky test