Skip to content

Integrate a spell and/or grammar check into build system #187

Closed

Description

@markmandel

It's super easy to miss misspelled words in our .md documentation files.

It would be great if there was a spellchecker (and maybe even a grammar / documentation helper?) integrated into the build system to ensure the documentation continues to be written well.

We could probably just install aspell and call it directly.

Or maybe something like write-good - but I don't know if we want to add node to our build images. Maybe there is a go version somewhere? Or an online service? Possibly worth exploring.

Activity

  1. added
    help wantedWe would love help on these issues. Please come help us!
    good first issueThese are great first issues. If you are looking for a place to start, start here!
    area/build-toolsDevelopment tooling. I.e. pretty much everything in the `build` directory.
    on Apr 27, 2018
  2. markmandel commented on May 8, 2018

    @markmandel
    MemberAuthor

    There is this docker image, that seems to get updated regularly.
    https://hub.docker.com/r/hochzehn/write-good/
    Could possibly be integrated into cloud builder and/or used as a make target.

  3. cyriltovena commented on Sep 6, 2018

    @cyriltovena
    Collaborator

    Started to use locally https://github.com/golangci/golangci-lint which advertise faster (also a lot less memory usage) than gometalinter, looks good so far.

    They have an optional spellchecker (https://github.com/client9/misspell).

    We could do a two birds one stone here ? Improve lint target and have grammar check.

    @markmandel Can you have a look at https://github.com/golangci/golangci-lint and let me know what do you think ?

  4. markmandel commented on Sep 6, 2018

    @markmandel
    MemberAuthor

    I think we looked at this a while back as well - for the same reasons. @enocom do you have any thoughts or feelings?

    Need to make sure our exclude list still works. I'd also like to add goimport testing too.

  5. enocom commented on Sep 6, 2018

    @enocom
    Contributor

    It would be nice to use misspell, especially if we're going to switch to golangci-lint.

  6. markmandel commented on Sep 6, 2018

    @markmandel
    MemberAuthor

    I say -- let's do it!

    Also linking #237 to this, as it looks like the work crosses between the tickets.

  7. added this to the 0.5.0 milestone on Feb 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    area/build-toolsDevelopment tooling. I.e. pretty much everything in the `build` directory.good first issueThese are great first issues. If you are looking for a place to start, start here!help wantedWe would love help on these issues. Please come help us!kind/documentationDocumentation for Agones

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions