Repository navigation
Remove testing utilities from production code #175
Description
Activity
Move to a separate namespace that is not included in the prod uberjar.
Move to a separate namespace that is not included in the prod uberjar.
this is a breaking change, because some some clients might be using this function. I am fine with this, since
docker-postgres!is just destructuring xiana cinfig and simply building testcontainer docker instance. maybe we can move it into examples, so anyone who will need it can copy paste itbut it is necessary to remove it if we dont want to force clients to depend on
testcontinersin their production artifacts.- linked a pull request that will close this issueFeature/175 remove testing utilities from production code #228
on Jul 19, 2022 New PR #233
- removed a link to a pull requestFeature/175 remove testing utilities from production code #228
on Sep 21, 2022 - linked a pull request that will close this issueMove test-containers dependency to test deps #233
on Sep 21, 2022
Function
docker-postgres!defined in namespaceframework.db.coreis only being used in test namespaces, whether we look at the framework codebase, its examples or the Frankie project. I doubt that I will ever be used in any production environment and for this reason I propose that it should be removed from production code.It also invites developers to expand configuration of their projects in a manner that I personally don't consider correct.
I agree that the function is valuable for testing purposes, but if we insist on keeping and maintaining it, we should move it to a separate project which can be later used strictly as a test dependency and not to be part of a production code.