You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Do not call 'IServiceCollection.BuildServiceProvider' in 'ConfigureServices' #187
services.AddExtCore(this.extensionsPath, false, new ExtCore.WebApplication.DefaultAssemblyProvider(services.BuildServiceProvider())
You will get the following warning:
warning ASP0000: Calling 'BuildServiceProvider' from application code results in an additional copy of singleton services being created. Consider alternatives such as dependency injecting services as parameters to 'Configure'.
Is this something you are going to address?
It is not recommended to use BuildServiceProvider inside ConfigureServices but the constructor of DefaultAssemblyProvider expects to get a ServiceProvider.
Activity
DmitrySikorsky commentedon Mar 5, 2021
Hi, thank you, I will review this part of code.