Skip to content

IAssemblyProvider too specific #105

Open

Description

@fraserkyle

I beleive that the IAssemblyProvider interface is too specific. I intend to use ExtCore to create a simple pluggable CMS which will allow installation of Packages containing ExtCore extensions.

Packages will be created as projects, containing json files, detailing the content of each package. A database table will be maintained containing reference to installed packages. My intention is to create a new Assembly Provider which will return assemblies for the packages recorded as installed on my SQL table.

Is this the intended use for the IAssemblyProvider interface? If so then can the path and includeSubpaths parameters within GetAssemblies be made properties of the implementation rather than the declaration?

Activity

  1. changed the title [-]IAssemblyProvider[/-] [+]IAssemblyProvider too specific[/+] on Jan 21, 2018
  2. DmitrySikorsky commented on Jan 22, 2018

    @DmitrySikorsky
    Member

    Yes, you are right. I think we could have 1 method in the interface:

    GetAssemblies(IAssemblyProviderOptions options)

    (But in this case IAssemblyProviderOptions will be just marker interface with no properties or methods defined. What do you think about that?)

  3. fraserkyle commented on Jan 22, 2018

    @fraserkyle
    Author

    Perfect. This would leave the options open to extension. :-)

  4. added this to the 5.0.0 milestone on Aug 8, 2019
  5. modified the milestones: 5.0.0, 6.0.0 on Nov 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions