Skip to content

Commit 7b14251

Browse files
committed
build with net7; cleanup
1 parent 7da09f0 commit 7b14251

4 files changed

Lines changed: 8 additions & 7 deletions

File tree

‎.github/workflows/dotnet.yml‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,10 +12,10 @@ jobs:
1212

1313
steps:
1414
- uses: actions/checkout@v3
15-
- name: Setup .NET 6.0.x
16-
uses: actions/setup-dotnet@v2
15+
- name: Setup .NET 7.0.x
16+
uses: actions/setup-dotnet@v3
1717
with:
18-
dotnet-version: 6.0.x
18+
dotnet-version: 7.0.x
1919
- name: Restore dependencies
2020
run: dotnet restore
2121
- name: Build

‎src/EntityGraphQL.AspNet/EntityGraphQL.AspNet.csproj‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
<Project Sdk="Microsoft.NET.Sdk" ToolsVersion="Current">
22

33
<PropertyGroup>
4-
<TargetFrameworks>netcoreapp3.1;net5.0;net6.0</TargetFrameworks>
4+
<TargetFrameworks>netcoreapp3.1;net5.0;net6.0;net7.0</TargetFrameworks>
55
<AssemblyName>EntityGraphQL.AspNet</AssemblyName>
66
<PackageId>EntityGraphQL.AspNet</PackageId>
77
<PackageVersion>4.3.0</PackageVersion>

‎src/EntityGraphQL.AspNet/WebSockets/GraphQLWebSocketServer.cs‎

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -177,9 +177,10 @@ public Task SendErrorAsync(Guid id, IEnumerable<GraphQLError> errors)
177177

178178
public void CompleteSubscription(Guid id)
179179
{
180-
if (subscriptions.ContainsKey(id))
180+
subscriptions.TryGetValue(id, out var subscription);
181+
if (subscription != null)
181182
{
182-
subscriptions[id].Dispose();
183+
subscription.Dispose();
183184
subscriptions.Remove(id);
184185
}
185186
}

‎src/EntityGraphQL.AspNet/WebSockets/WebSocketSubscription.cs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ namespace EntityGraphQL.AspNet.WebSockets
88
/// Ties the GraphQL subscription to the WebSocket connection.
99
/// </summary>
1010
/// <typeparam name="TEventType"></typeparam>
11-
internal class WebSocketSubscription<TQueryContext, TEventType> : IDisposable, IObserver<TEventType>
11+
internal sealed class WebSocketSubscription<TQueryContext, TEventType> : IDisposable, IObserver<TEventType>
1212
{
1313
private readonly Guid id;
1414
private readonly IObservable<TEventType> observable;

0 commit comments

Comments
 (0)