node/eslint.config.mjs at main · Ecco/node · GitHub

Repository navigation

1

2

3

4

5

6

7

8

9

10

11

12

13

14

15

16

17

18

19

20

21

22

23

24

25

26

27

28

29

30

31

32

33

34

35

36

37

38

39

40

41

42

43

44

45

46

47

48

49

50

51

52

53

54

55

56

57

58

59

60

61

62

63

64

65

66

67

68

69

70

71

72

73

74

75

76

77

78

79

80

81

82

83

84

85

86

87

88

89

90

91

92

93

94

95

96

97

98

99

100

101

102

103

104

105

106

107

108

109

110

111

112

113

114

115

116

117

118

119

120

121

122

123

124

125

126

127

128

129

130

131

132

133

134

135

136

137

138

139

140

141

142

143

144

145

146

147

148

149

150

151

152

153

154

155

156

157

158

159

160

161

162

163

164

165

166

167

168

169

170

171

172

173

174

175

176

177

178

179

180

181

182

183

184

185

186

187

188

189

190

191

192

193

194

195

196

197

198

199

200

201

202

203

204

205

206

207

208

209

210

211

212

213

214

215

216

217

218

219

220

221

222

223

224

225

226

227

228

229

230

231

232

233

234

235

236

237

238

239

240

241

242

243

244

245

246

247

248

249

250

251

252

253

254

255

256

257

258

259

260

261

262

263

264

265

266

267

268

269

270

271

272

273

274

275

276

277

278

279

280

281

282

283

284

285

286

287

288

289

290

291

292

293

294

295

296

297

298

299

300

301

302

303

304

305

306

307

308

309

310

311

312

313

314

315

316

317

318

319

320

321

322

323

324

325

326

327

328

329

330

331

332

333

334

335

336

337

338

339

340

341

342

343

344

345

346

347

348

349

350

351

352

353

354

355

356

357

358

359

360

361

362

363

364

365

366

367

368

369

370

371

372

373

374

375

376

377

378

379

380

381

382

383

384

385

386

387

388

389

390

391

392

393

394

395

396

397

398

399

400

401

402

403

404

405

406

407

408

409

410

411

412

413

414

415

416

417

418

419

420

421

422

423

424

425

426

427

428

429

430

431

432

433

434

435

436

437

438

439

440

441

442

443

444

445

446

447

448

449

450

451

452

453

454

455

456

457

458

459

460

461

import { readdirSync } from 'node:fs';

import Module from 'node:module';

import { fileURLToPath, URL } from 'node:url';

import benchmarkConfig from './benchmark/eslint.config_partial.mjs';

import docConfig from './doc/eslint.config_partial.mjs';

import libConfig from './lib/eslint.config_partial.mjs';

import testConfig from './test/eslint.config_partial.mjs';

import toolsConfig from './tools/eslint/eslint.config_partial.mjs';

import {

importEslintTool,

noRestrictedSyntaxCommonAll,

noRestrictedSyntaxCommonLib,

resolveEslintTool,

} from './tools/eslint/eslint.config_utils.mjs';

import nodeCore from './tools/eslint/eslint-plugin-node-core.js';

const { globalIgnores } = await importEslintTool('eslint/config');

const { default: js } = await importEslintTool('@eslint/js');

const { default: babelEslintParser } = await importEslintTool('@babel/eslint-parser');

const babelPluginSyntaxImportSource = resolveEslintTool('@babel/plugin-syntax-import-source');

const { default: jsdoc } = await importEslintTool('eslint-plugin-jsdoc');

const { default: regexpPlugin } = await importEslintTool('eslint-plugin-regexp');

const { default: markdown } = await importEslintTool('@eslint/markdown');

const { default: stylisticJs } = await importEslintTool('@stylistic/eslint-plugin');

nodeCore.RULES_DIR = fileURLToPath(new URL('./tools/eslint-rules', import.meta.url));

function filterFilesInDir(dirpath, filterFn) {

return readdirSync(dirpath)

.filter(filterFn)

.map((f) => `${dirpath}/${f}`);

}

// The Module._resolveFilename() monkeypatching is to make it so that ESLint is able to

// dynamically load extra modules that we install with it.

const ModuleResolveFilename = Module._resolveFilename;

const hacks = [

'eslint-formatter-tap',

];

Module._resolveFilename = (request, parent, isMain, options) => {

if (hacks.includes(request) && parent.id.endsWith('__placeholder__.js')) {

return resolveEslintTool(request);

}

return ModuleResolveFilename(request, parent, isMain, options);

};

export default [

// #region ignores

globalIgnores([

'**/node_modules/**',

'benchmark/fixtures/**',

'benchmark/tmp/**',

'doc/changelogs/CHANGELOG_V1*.md',

'!doc/changelogs/CHANGELOG_V18.md',

'lib/punycode.js',

'test/.tmp.*/**',

'test/addons/??_*',

// We want to lint only a few specific fixtures folders

'test/fixtures/*',

'!test/fixtures/console',

'!test/fixtures/errors',

'!test/fixtures/eval',

'!test/fixtures/source-map',

'test/fixtures/source-map/*',

'!test/fixtures/source-map/output',

...filterFilesInDir(

'test/fixtures/source-map/output',

// Filtering tsc output files (i.e. if there a foo.ts, we ignore foo.js):

(f, _, files) => f.endsWith('js') && files.includes(f.replace(/(\.[cm]?)js$/, '$1ts')),

),

'!test/fixtures/test-inspector-dom-storage.mjs',

'!test/fixtures/test-runner',

'test/fixtures/test-runner/*',

'!test/fixtures/test-runner/output',

...filterFilesInDir(

'test/fixtures/test-runner/output',

// Filtering tsc output files (i.e. if there a foo.ts, we ignore foo.js):

(f, _, files) => f.endsWith('js') && files.includes(f.replace(/\.[cm]?js$/, '.ts')),

),

'!test/fixtures/v8',

'!test/fixtures/vm',

]),

// #endregion

// #region general config

js.configs.recommended,

jsdoc.configs['flat/recommended'],

regexpPlugin.configs.recommended,

{

files: ['**/*.js'],

languageOptions: {

sourceType: 'commonjs',

},

},

{

plugins: {

jsdoc,

'@stylistic/js': stylisticJs,

'node-core': nodeCore,

},

languageOptions: {

parser: babelEslintParser,

parserOptions: {

babelOptions: {

plugins: [

babelPluginSyntaxImportSource,

],

},

requireConfigFile: false,

},

},

},

// #endregion

// #region general globals

{

languageOptions: {

globals: {

AsyncDisposableStack: 'readonly',

ByteLengthQueuingStrategy: 'readonly',

CompressionStream: 'readonly',

CountQueuingStrategy: 'readonly',

CustomEvent: 'readonly',

crypto: 'readonly',

Crypto: 'readonly',

CryptoKey: 'readonly',

DecompressionStream: 'readonly',

DisposableStack: 'readonly',

EventSource: 'readable',

fetch: 'readonly',

Float16Array: 'readonly',

FormData: 'readonly',

navigator: 'readonly',

QuotaExceededError: 'readonly',

ReadableStream: 'readonly',

ReadableStreamDefaultReader: 'readonly',

ReadableStreamBYOBReader: 'readonly',

ReadableStreamBYOBRequest: 'readonly',

ReadableByteStreamController: 'readonly',

ReadableStreamDefaultController: 'readonly',

Response: 'readonly',

TextDecoderStream: 'readonly',

TextEncoderStream: 'readonly',

TransformStream: 'readonly',

TransformStreamDefaultController: 'readonly',

ShadowRealm: 'readonly',

SubtleCrypto: 'readonly',

WritableStream: 'readonly',

WritableStreamDefaultWriter: 'readonly',

WritableStreamDefaultController: 'readonly',

WebSocket: 'readonly',

},

},

},

// #endregion

// #region general rules

{

rules: {

// ESLint built-in rules

// https://eslint.org/docs/latest/rules/

'accessor-pairs': 'error',

'array-callback-return': 'error',

'block-scoped-var': 'error',

'capitalized-comments': ['error', 'always', {

line: {

// Ignore all lines that have less characters than 20 and all lines

// that start with something that looks like a variable name or code.

ignorePattern: '.{0,20}$|[a-z]+ ?[0-9A-Z_.(/=:[#-]|std|http|ssh|ftp',

ignoreInlineComments: true,

ignoreConsecutiveComments: true,

},

block: {

ignorePattern: '.*',

},

}],

'logical-assignment-operators': ['error', 'always', { enforceForIfStatements: true }],

'default-case-last': 'error',

'dot-notation': 'error',

'eqeqeq': ['error', 'smart'],

'func-name-matching': 'error',

'func-style': ['error', 'declaration', { allowArrowFunctions: true }],

'no-constant-condition': ['error', { checkLoops: false }],

'no-constructor-return': 'error',

'no-duplicate-imports': 'error',

'no-else-return': 'error',

'no-lonely-if': 'error',

'no-mixed-requires': 'error',

'no-new-require': 'error',

'no-path-concat': 'error',

'no-proto': 'error',

'no-redeclare': ['error', { builtinGlobals: false }],

'no-restricted-modules': ['error', 'sys'],

'no-restricted-properties': [

'error',

{

object: 'assert',

property: 'deepEqual',

message: 'Use `assert.deepStrictEqual()`.',

},

{

object: 'assert',

property: 'notDeepEqual',

message: 'Use `assert.notDeepStrictEqual()`.',

},

{

object: 'assert',

property: 'equal',

message: 'Use `assert.strictEqual()` rather than `assert.equal()`.',

},

{

object: 'assert',

property: 'notEqual',

message: 'Use `assert.notStrictEqual()` rather than `assert.notEqual()`.',

},

{

property: '__defineGetter__',

message: '__defineGetter__ is deprecated.',

},

{

property: '__defineSetter__',

message: '__defineSetter__ is deprecated.',

},

{

property: 'webcrypto',

message: 'Use `globalThis.crypto`.',

},

],

'no-restricted-syntax': [

'error',

...noRestrictedSyntaxCommonAll,

...noRestrictedSyntaxCommonLib,

],

'no-self-compare': 'error',

'no-shadow-restricted-names': ['error', { reportGlobalThis: false }],

'no-template-curly-in-string': 'error',

'no-throw-literal': 'error',

'no-undef': ['error', { typeof: true }],

'no-undef-init': 'error',

'no-unused-expressions': ['error', { allowShortCircuit: true }],

'no-unused-vars': ['error', { args: 'none', caughtErrors: 'all' }],

'no-use-before-define': ['error', {

classes: true,

functions: false,

variables: false,

}],

'no-useless-call': 'error',

'no-useless-concat': 'error',

'no-useless-constructor': 'error',

'no-useless-return': 'error',

'no-var': 'error',

'no-void': 'error',

'one-var': ['error', { initialized: 'never' }],

'prefer-const': ['error', { ignoreReadBeforeAssign: true }],

'prefer-object-has-own': 'error',

'strict': ['error', 'global'],

'symbol-description': 'error',

'unicode-bom': 'error',

'valid-typeof': ['error', { requireStringLiterals: true }],

// ESLint recommended rules that we disable.

'no-inner-declarations': 'off',

'no-useless-assignment': 'off',

// JSDoc rules.

'jsdoc/require-jsdoc': 'off',

'jsdoc/require-param-description': 'off',

'jsdoc/require-returns-description': 'off',

'jsdoc/valid-types': 'error',

'jsdoc/no-defaults': 'error',

'jsdoc/no-undefined-types': 'off',

'jsdoc/require-param': 'off',

'jsdoc/check-tag-names': 'error',

'jsdoc/require-returns': 'error',

'jsdoc/check-line-alignment': ['error', 'any', {

tags: ['param', 'property', 'returns', 'file'],

wrapIndent: ' ',

}],

'jsdoc/check-alignment': 'error',

'jsdoc/reject-any-type': 'off',

'jsdoc/reject-function-type': 'off',

// RegExp recommended rules that we disable.

// Todo: Investigate which rules should be enabled.

'prefer-regex-literals': 'off',

'regexp/control-character-escape': 'off',

'regexp/match-any': 'off',

'regexp/negation': 'off',

'regexp/no-contradiction-with-assertion': 'off',

'regexp/no-dupe-characters-character-class': 'off',

'regexp/no-dupe-disjunctions': 'off',

'regexp/no-empty-alternative': 'off',

'regexp/no-legacy-features': 'off',

'regexp/no-misleading-capturing-group': 'off',

'regexp/no-obscure-range': 'off',

'regexp/no-potentially-useless-backreference': 'off',

'regexp/no-super-linear-backtracking': 'off',

'regexp/no-trivially-nested-quantifier': 'off',

'regexp/no-unused-capturing-group': 'off',

'regexp/no-useless-assertions': 'off',

'regexp/no-useless-character-class': 'off',

'regexp/no-useless-escape': 'off',

'regexp/no-useless-flag': 'off',

'regexp/no-useless-lazy': 'off',

'regexp/no-useless-non-capturing-group': 'off',

'regexp/no-useless-quantifier': 'off',

'regexp/no-useless-range': 'off',

'regexp/optimal-lookaround-quantifier': 'off',

'regexp/optimal-quantifier-concatenation': 'off',

'regexp/prefer-character-class': 'off',

'regexp/prefer-d': 'off',

'regexp/prefer-question-quantifier': 'off',

'regexp/prefer-star-quantifier': 'off',

'regexp/prefer-w': 'off',

'regexp/sort-flags': 'off',

'regexp/strict': 'off',

'regexp/use-ignore-case': 'off',

// Stylistic rules.

'@stylistic/js/arrow-parens': 'error',

'@stylistic/js/arrow-spacing': 'error',

'@stylistic/js/block-spacing': 'error',

'@stylistic/js/brace-style': ['error', '1tbs', { allowSingleLine: true }],

'@stylistic/js/comma-dangle': ['error', 'always-multiline'],

'@stylistic/js/comma-spacing': 'error',

'@stylistic/js/comma-style': 'error',

'@stylistic/js/computed-property-spacing': 'error',

'@stylistic/js/dot-location': ['error', 'property'],

'@stylistic/js/eol-last': 'error',

'@stylistic/js/function-call-spacing': 'error',

'@stylistic/js/indent': ['error', 2, {

ArrayExpression: 'first',

CallExpression: { arguments: 'first' },

FunctionDeclaration: { parameters: 'first' },

FunctionExpression: { parameters: 'first' },

MemberExpression: 'off',

ObjectExpression: 'first',

SwitchCase: 1,

assignmentOperator: 'off',

}],

'@stylistic/js/key-spacing': 'error',

'@stylistic/js/keyword-spacing': 'error',

'@stylistic/js/linebreak-style': 'error',

'@stylistic/js/max-len': ['error', {

code: 120,

ignorePattern: '^// Flags:',

ignoreRegExpLiterals: true,

ignoreTemplateLiterals: true,

ignoreUrls: true,

tabWidth: 2,

}],

'@stylistic/js/new-parens': 'error',

'@stylistic/js/no-confusing-arrow': 'error',

'@stylistic/js/no-extra-parens': ['error', 'functions'],

'@stylistic/js/no-multi-spaces': ['error', { ignoreEOLComments: true }],

'@stylistic/js/no-multiple-empty-lines': ['error', { max: 2, maxEOF: 0, maxBOF: 0 }],

'@stylistic/js/no-tabs': 'error',

'@stylistic/js/no-trailing-spaces': 'error',

'@stylistic/js/no-whitespace-before-property': 'error',

'@stylistic/js/object-curly-newline': 'error',

'@stylistic/js/object-curly-spacing': ['error', 'always'],

'@stylistic/js/one-var-declaration-per-line': 'error',

'@stylistic/js/operator-linebreak': ['error', 'after'],

'@stylistic/js/padding-line-between-statements': [

'error',

{ blankLine: 'always', prev: 'function', next: 'function' },

],

'@stylistic/js/quotes': ['error', 'single', { avoidEscape: true, allowTemplateLiterals: 'always' }],

'@stylistic/js/quote-props': ['error', 'consistent'],

'@stylistic/js/rest-spread-spacing': 'error',

'@stylistic/js/semi': 'error',

'@stylistic/js/semi-spacing': 'error',

'@stylistic/js/space-before-blocks': ['error', 'always'],

'@stylistic/js/space-before-function-paren': ['error', {

anonymous: 'never',

named: 'never',

asyncArrow: 'always',

}],

'@stylistic/js/space-in-parens': 'error',

'@stylistic/js/space-infix-ops': 'error',

'@stylistic/js/space-unary-ops': 'error',

'@stylistic/js/spaced-comment': ['error', 'always', {

'block': { 'balanced': true },

'exceptions': ['-'],

}],

'@stylistic/js/template-curly-spacing': 'error',

// Custom rules in tools/eslint-rules.

'node-core/no-unescaped-regexp-dot': 'error',

'node-core/no-duplicate-requires': 'error',

'node-core/prefer-proto': 'error',

'node-core/prefer-optional-chaining': 'error',

},

},

// #endregion

// #region markdown config

{

files: ['**/*.md'],

plugins: {

markdown,

},

processor: 'markdown/markdown',

},

{

files: ['**/*.md/*.{js,cjs}'],

languageOptions: {

parserOptions: {

ecmaFeatures: { impliedStrict: true },

},

},

rules: { strict: 'off' },

},

{

files: [

'**/*.md/*.mjs',

'doc/api/esm.md/*.js',

'doc/api/packages.md/*.js',

],

languageOptions: {

sourceType: 'module',

},

rules: { 'no-restricted-globals': [

'error',

{

name: '__filename',

message: 'Use import.meta.url instead.',

},

{

name: '__dirname',

message: 'Not available in ESM.',

},

{

name: 'exports',

message: 'Not available in ESM.',

},

{

name: 'module',

message: 'Not available in ESM.',

},

{

name: 'require',

message: 'Use import instead.',

},

{

name: 'Buffer',

message: "Import 'Buffer' instead of using the global.",

},

{

name: 'process',

message: "Import 'process' instead of using the global.",

},

] },

},

// #endregion

// #region partials

...benchmarkConfig,

...docConfig,

...libConfig,

...testConfig,

...toolsConfig,

// #endregion

];