You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Get mime type "application/octet-stream" for wasm files #1575
Hi @evilebottnawi
It seems like package "send" use a old version of node mime package, therefore, the .wasm file has wrong mime type.
There is a PR which have been merged since one month ago, so the issue should be fixed after next update.
Hi @evilebottnawi
The "send" package is used by express.js, so I think there is no need to add a new pr.
But we need to wait for the next release of express.js.
It seems like it should be released with send@0.16.2, but it didn't.
And this issue expressjs/express#3589 says it will be released with express@4.17, but 4.17 disappeared and it seems like the next release will be 5.0.0 (There is a new release 5.0.0-alpha).
So, ... I don't know....
If this is important, maybe we could add express.static.mime.types["wasm"] = "application/wasm"; until the next release of express.
@evilebottnawi
I don't think this can fixed, or, for now it can't.
It seems like there isn't express@4.17, the latest release is 4.16.4.
And the issue is caused by send@0.16.2 (bind with express.js) which lock mime to @1.4.1, and the latest release of send is released on Feb 8, 2018.
Activity
alexander-akait commentedon Nov 20, 2018
@samsam2310 can't reproduce, please create minimum reproducible test repo
samsam2310 commentedon Nov 21, 2018
Hi @evilebottnawi
Here is the test repo: https://github.com/samsam2310/wp-bug
I have tried this and got the same result, hope this will help.
Thanks
samsam2310 commentedon Nov 26, 2018
Hi @evilebottnawi
It seems like package "send" use a old version of node mime package, therefore, the .wasm file has wrong mime type.
There is a PR which have been merged since one month ago, so the issue should be fixed after next update.
pillarjs/send#154
alexander-akait commentedon Nov 26, 2018
@samsam2310 feel free to send a PR with fix
samsam2310 commentedon Nov 27, 2018
Hi @evilebottnawi
The "send" package is used by express.js, so I think there is no need to add a new pr.
But we need to wait for the next release of express.js.
alexander-akait commentedon Nov 27, 2018
@samsam2310 Do you have link on
express.jsissue?samsam2310 commentedon Nov 27, 2018
@evilebottnawi You can take a look about the PR I posted above : pillarjs/send#154
It seems like it should be released with send@0.16.2, but it didn't.
And this issue expressjs/express#3589 says it will be released with express@4.17, but 4.17 disappeared and it seems like the next release will be 5.0.0 (There is a new release 5.0.0-alpha).
So, ... I don't know....
If this is important, maybe we could add
express.static.mime.types["wasm"] = "application/wasm";until the next release of express.alexander-akait commentedon Nov 27, 2018
@samsam2310 strange,
Yes, it will be in the 4.17 release +1should be solve 😕 Can you send a PR with test, maybe we need update depssamsam2310 commentedon Nov 27, 2018
@evilebottnawi
I don't think this can fixed, or, for now it can't.
It seems like there isn't express@4.17, the latest release is 4.16.4.
And the issue is caused by send@0.16.2 (bind with express.js) which lock mime to @1.4.1, and the latest release of send is released on Feb 8, 2018.
alexander-akait commentedon Nov 27, 2018
@samsam2310 hm, here PR https://github.com/expressjs/express/pull/3778/files, maybe we need workaround before this will be released
samsam2310 commentedon Nov 27, 2018
@evilebottnawi ok, I can make a PR with a workaround solution.
Workaround for issue webpack#1575
Workaround for issue webpack#1575
fix(Server): Workaround for .wasm file mime type (webpack#1575)
fix(Server): mime type for wasm in contentBase directory (#1575) (#1580)