Pass shareScope through to ContainerPlugin & ContainerReferencePlugin - #16031

The committers listed above are authorized under a signed CLA.

• ✅ login: evantd / name: Evan Dower (1492735)

For maintainers only:

• This needs to be documented (issue in webpack/webpack.js.org will be filed when merged)
• This needs to be backported to webpack 4 (issue will be created when merged)

Hi @evantd.

Just a little hint from a friendly bot about the best practice when submitting pull requests:

Don't submit pull request from your own main branch. It's recommended to create a feature branch for the PR.

You don't have to change it for this PR, just make sure to follow this hint the next time you submit a PR.

It looks like failures are sort of common. I saw a pull request that only changed the readme, and it also had 2 failed checks. I don't think that these failures are related to my change. It doesn't look like I can retry them either, at least as far as I can tell.

It looks like @sokra and/or @ScriptedAlchemy would be the right people to review this.

Good catch. Assuming both plugins under the hood still call apply(compiler) - which they should. Then I think this change looks good to me and would ensure plugins still work without having to manually apply 3-4 plugins just to use container or container reference independently

Yay! Yeah, I'm using an alternate shareScope for a work project and this change makes it work for me. I currently just apply a patch to node_modules in a postinstall script, and I'd love to stop doing that.

Is there anything more that I should be doing to keep this moving forward?

@sokra @vankop

Since this is approved, should I expect it to be included in the next release?

Can take a little time to move through the webpack org depending on what the change is. This seems small so I imagine it would be a quicker turnaround.

Nice thing about webpack is you can insall it over npm off a git branch since there's no build - so that might be useful in the interm

Thanks

I found myself needing to check if my version was new enough, so for anybody else (or future me), this is fixed in 5.74.0.