Repository navigation
Resolves: Add a CI/CD pipeline with GitHub Actions - #1057
Merged
fabiosantoscode merged 16 commits intoOct 20, 2021
Merged
Conversation
| name: "Logs ${{ matrix.os }} - nodejs ${{ matrix.node-version }}" | ||
| path: logs/ | ||
|
|
||
| deploy: |
Collaborator
There was a problem hiding this comment.
This entire step should be left out, I believe.
Terser is still published to NPM by hand, and moving to a flow like that should at least be a separate PR
Contributor
Author
There was a problem hiding this comment.
Hi @fabiosantoscode
to be sure I understood you correctly, you would like the build and deploy jobs to be on separate PRs ?
Something like this:
- PR-1
name: CI/CD pipeline
on: [ push, pull_request, workflow_dispatch ]
jobs:
build:
name: "Build ${{ matrix.os }} node${{ matrix.node-version }}"
runs-on: ${{ matrix.os }}
strategy:
matrix:
os: [ ubuntu-latest, windows-latest ]
node-version: [ 10.x, 12.x, 14.x, 16.x ]
outputs:
package_version: ${{ steps.proj_ver_determiner.outputs.package_version }}
package_version_tag: ${{ steps.proj_ver_determiner.outputs.package_version_tag }}
latest_github_tag: ${{ steps.proj_ver_determiner.outputs.latest_github_tag }}
should_deploy: ${{ steps.proj_ver_determiner.outputs.should_deploy }}
steps:
...
- PR-2
+++
deploy:
if: needs.build.outputs.should_deploy == 'true'
needs: build
runs-on: ubuntu-latest
steps:
...
Collaborator
There was a problem hiding this comment.
I think there shouldn't be a deploy step for now.
Contributor
Author
There was a problem hiding this comment.
Understood.
We'll make the changes promptly 馃檪
Collaborator
|
Hello there! I left just one comment, otherwise this looks good! |
Collaborator
|
Hey! Sorry I'm late! This looks good to go. Thanks! |
4 of 11 tasks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pipeline runs:
buildjob executes on every push commit, every PR and when the pipeline is run manuallydeployjob executes only on a push commit to the default branch, that contains a new version in thepackage.jsonNPM_TOKENGH_USER_EMAILandGH_USER_NAMEPlease let us know if anything could be done better and/or if any other automation is required by the project! We would be happy to improve it to satisfactory completion 馃檪
Resolves #1056