Skip to content

Optimization - Use faster null checking - #96

Merged
nblumhardt merged 2 commits into
serilog:devfrom
rafaelsc:optimization/fastNullCheck
Jul 23, 2020
Merged

nblumhardt merged 2 commits into
serilog:devfrom
rafaelsc:optimization/fastNullCheck

Conversation

@rafaelsc

Copy link
Copy Markdown
Contributor

What issue does this PR address?
None

Does this PR introduce a breaking change?
No

Please check if the PR fulfills these requirements

  • The commit follows our guidelines
  • Unit Tests for the changes have been added (for bug fixes / features)

Other Information:

  • Micro-optimization: Replace null checking to use is null to a 'faster' comparison. (Possible a very insignificant improvement)
  • Code Improvement: Add readonly to the static SyncRoot

@rafaelsc rafaelsc changed the title Optimization: Use faster null check Optimization - Use faster null checking Jul 18, 2020
@nblumhardt

Copy link
Copy Markdown
Member

Nice spotting on the sync root! Let's give this style a shot 👍

@nblumhardt
nblumhardt merged commit e992708 into serilog:dev Jul 23, 2020
@rafaelsc
rafaelsc deleted the optimization/fastNullCheck branch July 23, 2020 05:49
@nblumhardt nblumhardt mentioned this pull request Jul 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants