Repository navigation
Fix lookups of 0 keys - #594
Merged
Merged
Conversation
Collaborator
|
Looks good to me, thank you :) |
Contributor
|
@movermeyer, thnx for the fix! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
Fixes #593
#457 introduced a bug where
0was no longer considered an integer, and so lookups of0keys failed.What approach did you choose and why?
Fixed the regex to allow
0, and added more test coverage.What should reviewers focus on?
🤷 Alright regex?
The impact of these changes
Lookups of keys that end in
.0will work once again.