Stop gap solution for long output on test cases - #45882
Merged
Merged
Conversation
byroot
approved these changes
Aug 24, 2022
byroot
left a comment
Member
There was a problem hiding this comment.
Fine by me as a quick fix than we can easily backport until the full solution comes around.
jhawthorn
reviewed
Aug 24, 2022
Co-authored-by: John Hawthorn <john@hawthorn.email>
tenderlove
added a commit
that referenced
this pull request
Aug 24, 2022
Stop gap solution for long output on test cases
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch just changes the inspect method on test case instances.
Seeing test instance internals probably isn't helpful when an exception
is raised (for example a
NoMethodError).This isn't as good as #45122, but should fix #45121
I don't think this is great, but should fix the immediate pain. This does make me think we should have an API in Ruby for telling
inspectwhat instance variables we would like it to use.The implementation of
inspectsimply loops over all instance variables, but interestingly it doesn't call theinstance_variablesmethod to determine what IVs to inspect.To me, it feels like these two objects should have different inspect output, but they don't:
Anyone have any thoughts on this PR or the above thing? I'm happy to file a redmine ticket wrt the inspect feature.