Repository navigation
Include source and documdnts files only in the gem file. - #1391
Merged
Merged
Conversation
Member
|
Thanks! No, we're not using the Hoe stuff anymore. There is an open issue for it's removal #1328. |
Contributor
Author
This was referenced Mar 12, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Version 3.9.1 gem
About latest stable version 3.9.1 gem,
test,exampledirectories was not included in the gem file.Latest master branch
But about latest master branch, seeing
puma.gemspec, all the file is included in gem files includingtestandexampledirectory.I think maybe we do not want to ship development files such as
Gemfile,.githubdirectory, and etc.After modification
So, I modified gemspec file to only include source and document files in the gem file.
The result is like this.
Rails, RSpec are using this pattern as a reference.
https://github.com/rails/rails/blob/master/activesupport/activesupport.gemspec#L20
https://github.com/rspec/rspec-core/blob/master/rspec-core.gemspec#L16-L17
How do you think?
My concern is
hoeinRakefile.Actually are you using
hoeto generate gemspec file or release? If not, I think it might be better to remove the logic inRakefile.https://github.com/puma/puma/blob/master/Rakefile#L15