Skip to content

Create a CMake option to control whether or not RTTI is enabled - #8347

Merged
acozzette merged 1 commit into
protocolbuffers:masterfrom
floriansimon1:allow-disabling-rtti-from-cmake-command-line
Mar 2, 2021
Merged

acozzette merged 1 commit into
protocolbuffers:masterfrom
floriansimon1:allow-disabling-rtti-from-cmake-command-line

Conversation

@floriansimon1

Copy link
Copy Markdown

This is useful for Conan recipes that build Protobuf, in which
whatever we want to enable has to be enabled in the initial command line.
Without this, the people maintaining the recipe have to patch the CMake
setup of Protobuf before building the binaries.

Closes #5541

@google-cla

google-cla Bot commented Feb 25, 2021

Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

This is useful for Conan recipes that build Protobuf, in which
whatever we want to enable has to be enabled in the initial command line.
Without this, the people maintaining the recipe have to patch the CMake
setup of Protobuf before building the binaries.

Closes #5541
@acozzette

Copy link
Copy Markdown
Collaborator

Thanks, @floriansimon1.

@floriansimon1

Copy link
Copy Markdown
Author

My pleasure!

Do we know when the next release is planned?

@acozzette

Copy link
Copy Markdown
Collaborator

We don't have a set release schedule but we seem to average once every quarter or so. If you want to have this in a release version sooner then feel free to send me another PR cherry-picking this to the 3.15.x branch because we are probably going to do a 3.15.4 release this week.

@floriansimon1

floriansimon1 commented Mar 2, 2021 via email

Copy link
Copy Markdown
Author

@floriansimon1
floriansimon1 deleted the allow-disabling-rtti-from-cmake-command-line branch March 2, 2021 19:21
@floriansimon1

Copy link
Copy Markdown
Author

@acozzette > There! #8361

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add CMake option to define GOOGLE_PROTOBUF_NO_RTTI

3 participants