Skip to content

Upgrade to latest version of SVG Optimizer - #886

Merged
colebemis merged 11 commits into
mainfrom
ep/upgrade-svgo
Jan 5, 2023
Merged

colebemis merged 11 commits into
mainfrom
ep/upgrade-svgo

Conversation

@eliperkins

@eliperkins eliperkins commented Dec 20, 2022 •

Copy link
Copy Markdown
Contributor

This includes a bug fix which prevents malformed SVGs when rendering on macOS or iOS platforms.

Closes #866

Before (in GitHub.app on iOS 16.2) After (in GitHub.app on iOS 16.2)
Simulator Screen Shot - iPhone 14 Pro - 2022-12-20 at 17 59 44 Simulator Screen Shot - iPhone 14 Pro - 2022-12-20 at 18 11 10

Note gear-16, person-fill-24 and link-16 all appearing incorrectly in the before screenshot, and then rendering correctly in the after.

@eliperkins
eliperkins requested a review from a team as a code owner December 20, 2022 22:56
@eliperkins
eliperkins requested a review from colebemis December 20, 2022 22:56
@changeset-bot

changeset-bot Bot commented Dec 20, 2022 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 7efed67

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/octicons Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@eliperkins
eliperkins temporarily deployed to github-pages December 20, 2022 22:59 — with GitHub Actions Inactive
@eliperkins
eliperkins temporarily deployed to github-pages December 20, 2022 23:12 — with GitHub Actions Inactive
@eliperkins
eliperkins temporarily deployed to github-pages December 20, 2022 23:59 — with GitHub Actions Inactive
@eliperkins
eliperkins temporarily deployed to github-pages December 21, 2022 14:12 — with GitHub Actions Inactive
@eliperkins
eliperkins temporarily deployed to github-pages January 3, 2023 18:32 — with GitHub Actions Inactive
@eliperkins

Copy link
Copy Markdown
Contributor Author

This is blocked by #889

@eliperkins
eliperkins temporarily deployed to github-pages January 4, 2023 14:39 — with GitHub Actions Inactive
@eliperkins
eliperkins temporarily deployed to github-pages January 4, 2023 15:51 — with GitHub Actions Inactive
@eliperkins
eliperkins temporarily deployed to github-pages January 4, 2023 17:11 — with GitHub Actions Inactive
@eliperkins

Copy link
Copy Markdown
Contributor Author

Alright, after incorporating #889 , this should be good to go again!

@tallys tallys self-assigned this Jan 5, 2023
@tallys
tallys requested review from a team, rezrah and tallys January 5, 2023 16:54
@tallys tallys removed their assignment Jan 5, 2023
@colebemis
colebemis merged commit b5a1530 into main Jan 5, 2023
@colebemis
colebemis deleted the ep/upgrade-svgo branch January 5, 2023 17:27
@primer-css primer-css mentioned this pull request Jan 5, 2023

This branch was successfully deployed

1 active deployment
github-pages — 7efed67e Deployed Jan 5, 2023 by colebemis
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Some icons render incorrectly or throw warnings when used in iOS, macOS xcasset bundles

4 participants